From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb: fix first descriptor fetch error handling
Date: Sat, 11 Apr 2015 19:01:04 +0200 [thread overview]
Message-ID: <201504111901.05012.marex@denx.de> (raw)
In-Reply-To: <1428550069-9761-1-git-send-email-swarren@wwwdotorg.org>
On Thursday, April 09, 2015 at 05:27:49 AM, Stephen Warren wrote:
> When fetching the first descriptor from a new device, only validate that
> we received at least 8 bytes, not that we received the entire descriptor.
> The reasoning is:
> - The code only uses fields in the first 8 bytes, so that's all we need
> to have fetched at this stage.
> - The smallest maxpacket size is 8 bytes. Before we know the actual
> maxpacket the device uses, the USB controller may only accept a single
> packet (see the DWC2 note in the comment added in the commit).
> Consequently we are only guaranteed to receive 1 packet (at least 8
> bytes) even in a non-error case.
>
> Fixes: 1a7758044b04 ("usb: Early failure when the first descriptor read
> fails or is invalid")
> Cc: Paul Kocialkowski <contact@paulk.fr>
> Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
Applied to u-boot-usb/next, thanks!
Best regards,
Marek Vasut
prev parent reply other threads:[~2015-04-11 17:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-09 3:27 [U-Boot] [PATCH] usb: fix first descriptor fetch error handling Stephen Warren
2015-04-11 17:01 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201504111901.05012.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox