From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] usb: dwc2: implement interrupt transfers
Date: Sat, 11 Apr 2015 19:04:58 +0200 [thread overview]
Message-ID: <201504111904.58286.marex@denx.de> (raw)
In-Reply-To: <1428721522-10912-2-git-send-email-swarren@wwwdotorg.org>
On Saturday, April 11, 2015 at 05:05:22 AM, Stephen Warren wrote:
> As best I can tell, there's no difference between bulk and interrupt
> transfers in terms of how the HW should be programmed, at least given
> that we're executing one transaction at a time rather than scheduling
> them into frames for maximum throughput.
>
> This patch ends up sharing the toggle bit state between bulk and
> interrupt transfers on a particular EP. However I believe this is fine;
> AFAIK a given EP either uses bulk or interrupt transfers and doesn't mix
> them.
>
> This patch doesn't do anything with the "interval" parameter for
> interrupt transfers, but then most other USB controller drivers in U-Boot
> don't either.
>
> It turns out that one of my keyboards is happy to work using control
> transfers but the other only gives non-zero "HID reports" via interrupt
> transfers.
>
> Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
Applied to u-boot-usb/topic/dwc2, thanks!
Best regards,
Marek Vasut
next prev parent reply other threads:[~2015-04-11 17:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-11 3:05 [U-Boot] [PATCH 1/2] usb: dwc2: correctly program hcchar for LS devices Stephen Warren
2015-04-11 3:05 ` [U-Boot] [PATCH 2/2] usb: dwc2: implement interrupt transfers Stephen Warren
2015-04-11 17:04 ` Marek Vasut [this message]
2015-04-11 17:04 ` [U-Boot] [PATCH 1/2] usb: dwc2: correctly program hcchar for LS devices Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201504111904.58286.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox