public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb: dwc2: retry NAK'd interrupt transfers
Date: Mon, 13 Apr 2015 01:19:18 +0200	[thread overview]
Message-ID: <201504130119.18388.marex@denx.de> (raw)
In-Reply-To: <1428810722-20673-1-git-send-email-swarren@wwwdotorg.org>

On Sunday, April 12, 2015 at 05:52:02 AM, Stephen Warren wrote:
> IIUC, interrupt transfers are NAK'd by devices until they wish to trigger
> an interrupt, and e.g. EHCI controllers retry these in HW until they are
> ACK'd. However, DWC2 doesn't seem to retry, so we need to do this in SW.
> In practice, I've seen DWC2_HCINT_FRMOVRUN happen too. I'm not quite sure
> what this error implies; perhaps it's related to how near the end of a
> USB frame we're at when the interrupt transfer is initiated? Anyway,
> retrying this temporary error seems to be necessary too.
> 
> With all these commits applied, both my USB keyboards (one LS Lenovo and
> one FS Dell) work correctly when there is no USB hub between the SoC and
> the keyboard; We still need split transactions to be implemented for hubs
> to work.
> 
> Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>

Applied to u-boot-usb/topic/dwc2 , thanks!

Best regards,
Marek Vasut

      reply	other threads:[~2015-04-12 23:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-12  3:52 [U-Boot] [PATCH] usb: dwc2: retry NAK'd interrupt transfers Stephen Warren
2015-04-12 23:19 ` Marek Vasut [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201504130119.18388.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox