From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Thu, 16 Apr 2015 13:20:10 -0400 Subject: [U-Boot] [PATCH] fw_env.h: include autoconf.h In-Reply-To: <7c8f1b7e3881f278cd42e3ab43c0d6e269df5d21.1429027426.git.marcel.ziswiler@toradex.com> References: <7c8f1b7e3881f278cd42e3ab43c0d6e269df5d21.1429027426.git.marcel.ziswiler@toradex.com> Message-ID: <20150416172010.GB16702@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Apr 14, 2015 at 09:50:47PM +0200, Marcel Ziswiler wrote: > From: Max Krummenacher > > Without this, when CONFIG_ENV_VARS_UBOOT_CONFIG is active we get > a compile time error when doing 'make env'. > In file included from tools/env/fw_env.c:117:0: > include/env_default.h:110:11: error: expected ?}? before ?CONFIG_SYS_ARCH? > > When building U-Boot this is included indirectly by the compiler switch > -include > /home/trdx/git.toradex.com/u-boot-2014.10-toradex/include/linux/kconfig.h > > Signed-off-by: Max Krummenacher > Signed-off-by: Marcel Ziswiler > --- > This is an issue on all tegra boards due CONFIG_ENV_VARS_UBOOT_CONFIG > being defined in the tegra-common.h header file. > > I already did reported this once last November but did not get any > useful insights back then: Ug. I'm cc'ing a few distro people since this makes it further clear that by whatever name a distro packages fw_setenv/fw_getenv these are really machine (to the extent U-Boot is built) specific applications due to the need to include a copy of the default environment so that we can support making sure that variables that aren't supposed to be overwritten are not overwritten (see the fw_getdefenv call in tools/env/fw_env.c::fw_env_write). I'll let Masahiro comment on if this is the best way to fix the compile problem. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: