From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Fri, 17 Apr 2015 11:30:36 +0200 Subject: [U-Boot] [PATCH v3 7/7] colibri_vf: Enable USB support for Colibri Vybrid In-Reply-To: <20150417092103.GA5646@Sanchayan-Arch.toradex.int> References: <201504162221.11451.marex@denx.de> <20150417092103.GA5646@Sanchayan-Arch.toradex.int> Message-ID: <201504171130.37042.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Friday, April 17, 2015 at 11:21:03 AM, maitysanchayan at gmail.com wrote: > Hello, > > On 15-04-16 22:21:11, Marek Vasut wrote: > > On Wednesday, April 15, 2015 at 12:54:28 PM, Sanchayan Maity wrote: > > > Enable USB support on Toradex Colibri Vybrid Modules. > > > > > > Signed-off-by: Sanchayan Maity > > > --- > > > > > > board/toradex/colibri_vf/colibri_vf.c | 25 +++++++++++++++++++++-- > > > include/configs/colibri_vf.h | 37 > > > > > > +++++++++++++++++++++++++++++++++++ 2 files changed, 60 insertions(+), > > > 2 deletions(-) > > > > > > diff --git a/board/toradex/colibri_vf/colibri_vf.c > > > b/board/toradex/colibri_vf/colibri_vf.c index e7bc6c1..054e6f9 100644 > > > --- a/board/toradex/colibri_vf/colibri_vf.c > > > +++ b/board/toradex/colibri_vf/colibri_vf.c > > > @@ -197,7 +197,8 @@ static void clock_init(void) > > > > > > clrsetbits_le32(&ccm->ccgr0, CCM_REG_CTRL_MASK, > > > > > > CCM_CCGR0_UART0_CTRL_MASK); > > > > > > clrsetbits_le32(&ccm->ccgr1, CCM_REG_CTRL_MASK, > > > > > > - CCM_CCGR1_PIT_CTRL_MASK | CCM_CCGR1_WDOGA5_CTRL_MASK); > > > + CCM_CCGR1_PIT_CTRL_MASK | CCM_CCGR1_WDOGA5_CTRL_MASK | > > > + CCM_CCGR1_USBC0_CTRL_MASK); > > > > You probably want to flip these CCM regs only if CONFIG_CI_UDC is enabled > > or something along those lines, right ? > > Yes, that would be be better. Will send a new corrected patch for this. > I assume since there are no issues with the rest of the patchset so > sending a respin of this last patch would do?! > > Thanks for the feedback and catching this. Yup, resending just the last patch is fine :) Best regards, Marek Vasut