From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pavel Machek <pavel@denx.de>
Date: Fri, 17 Apr 2015 22:44:41 +0200
Subject: [U-Boot] [PATCH RESEND 1/3] driver/ddr/altera: Add DDR driver
 for Altera's SDRAM controller
In-Reply-To: <553124B1.3040401@opensource.altera.com>
References: <1429193516-11179-1-git-send-email-dinguyen@opensource.altera.com>
 <1429193516-11179-2-git-send-email-dinguyen@opensource.altera.com>
 <20150417123127.GC9464@amd>
 <553124B1.3040401@opensource.altera.com>
Message-ID: <20150417204441.GA2378@amd>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi!

> >> +#define \
> >> +SDR_CTRLGRP_MPTHRESHOLDRST_0_THRESHOLDRSTCYCLES_31_0_LSB 0
> >> +#define  \
> >> +SDR_CTRLGRP_MPTHRESHOLDRST_0_THRESHOLDRSTCYCLES_31_0_MASK \
> >> +0xffffffff
> >> +/* Register template: sdr::ctrlgrp::mpthresholdrst::mpthresholdrst_1       */
> >> +#define \
> >> +SDR_CTRLGRP_MPTHRESHOLDRST_1_THRESHOLDRSTCYCLES_63_32_LSB 0
> >> +#define \
> >> +SDR_CTRLGRP_MPTHRESHOLDRST_1_THRESHOLDRSTCYCLES_63_32_MASK \
> >> +0xffffffff
> >> +/* Register template: sdr::ctrlgrp::mpthresholdrst::mpthresholdrst_2       */
> >> +#define \
> >> +SDR_CTRLGRP_MPTHRESHOLDRST_2_THRESHOLDRSTCYCLES_79_64_LSB 0
> >> +#define \
> >> +SDR_CTRLGRP_MPTHRESHOLDRST_2_THRESHOLDRSTCYCLES_79_64_MASK \
> >> +0x0000ffff
> > 
> > Can we get slightly shorter define names?
> 
> I did think about shortening these defines a bit, but came to this
> reason that I should leave these alone. These defines are generated from
> the tools AFAICT. I don't think any sane person would try to have
> defines this long. So I still want to try to save the use case that the
> driver can still be used with the autogenerated header file from the
> tools in some form.

Ok.

[I'd suggest placing the defines on single lines, ignoring 80 column
rule, but then checkpatch would scream, so I guess it is ok as it is.]

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html