From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Tue, 21 Apr 2015 12:21:35 +0200 Subject: [U-Boot] [PATCH] usb: Remove unused variable in usb_setup_descriptor() In-Reply-To: <5534AA77.3050406@redhat.com> References: <1429436001-8727-1-git-send-email-hdegoede@redhat.com> <5534AA77.3050406@redhat.com> Message-ID: <201504211221.35802.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Monday, April 20, 2015 at 09:27:51 AM, Hans de Goede wrote: > Hi, > > On 19-04-15 15:36, Simon Glass wrote: > > Hi Hans, > > > > On 19 April 2015 at 03:33, Hans de Goede wrote: > >> The compiler did not catch this as it was marked __maybe_unused. > >> > >> Signed-off-by: Hans de Goede > >> --- > >> > >> common/usb.c | 2 -- > >> 1 file changed, 2 deletions(-) > > > > Acked-by: Simon Glass > > > > Thanks for spotting this. Another minor problem is that > > get_descriptor_len() allocates a 512-byte buffer but only 64 bytes is > > needed. > > Good one, someone should probably write a patch for this. Consider such > a patch Acked-by: Hans de Goede . > > Whom is going to pick up these fixes and upstream them ? Applied to u-boot-usb/master, thanks! Best regards, Marek Vasut