From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] spl: spl_mmc: Clearer structure in spl_mmc_load_image and cosmetics
Date: Tue, 21 Apr 2015 09:32:36 -0400 [thread overview]
Message-ID: <20150421133236.GF16702@bill-the-cat> (raw)
In-Reply-To: <1429471809-17069-1-git-send-email-contact@paulk.fr>
On Sun, Apr 19, 2015 at 09:30:08PM +0200, Paul Kocialkowski wrote:
> This refactors spl_mmc_load_image to use a switch/case structure and easier
> to understand spl_start_uboot checks. It also drops fallbacks on boot devices
> that were not selected in the first place.
I don't like the dropping fallback on boot devices part and this is
going to break existing setups. What some people do is on platforms
where the ROM doesn't grok FAT they still have u-boot.img on FAT and
just keep SPL written to the raw device. Then booting from both raw or
RAW+FAT works.
> Lines that go beyond 80 chars are also reduced by reducing the number of tabs.
> Debug and error strings are refctored to match a common style.
I like the strings having a common style. Please make sure that
checkpatch is happy about how you re-indent the code too, thanks.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150421/207a80a8/attachment.sig>
next prev parent reply other threads:[~2015-04-21 13:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-19 19:30 [U-Boot] [PATCH 1/2] spl: spl_mmc: Clearer structure in spl_mmc_load_image and cosmetics Paul Kocialkowski
2015-04-19 19:30 ` [U-Boot] [PATCH 2/2] spl: spl_mmc: Partition raw boot mode for eMMC Paul Kocialkowski
2015-04-21 13:32 ` Tom Rini [this message]
2015-04-27 8:21 ` [U-Boot] [PATCH 1/2] spl: spl_mmc: Clearer structure in spl_mmc_load_image and cosmetics Paul Kocialkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150421133236.GF16702@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox