public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] u-boot: adjust config_cmd_default.h not to raise ton of warnings
Date: Sun, 3 May 2015 21:33:29 +0200	[thread overview]
Message-ID: <20150503193329.GA17791@amd> (raw)
In-Reply-To: <55464F88.7010900@wwwdotorg.org>

On Sun 2015-05-03 10:40:40, Stephen Warren wrote:
> On 05/03/2015 04:01 AM, Pavel Machek wrote:
> > On Fri 2015-05-01 09:24:02, Stephen Warren wrote:
> >> On 05/01/2015 03:14 AM, Pavel Machek wrote:
> >>>
> >>> If there's duplicty between config system and config_cmd_default, a
> >>> ton of warnings is raised, because one uses plain defines, and other
> >>> defines it to 1. Adjust config_cmd_default.h not to provoke the
> >>> warnings.
> >>
> >> I believe the correct way to fix this is to fix the board config files that
> >> cause the defines to be duplicated.
> > 
> > Yes, I'm doing that, too (patch is waiting for Marek to be applied),
> > but that does not really fix the problem -- it really should be
> > consistent; otherwise we'll hit subtle bugs sooner or later.
> 
> I don't believe consistency requires complicating the defaults file.

I do. It already causes problems.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  reply	other threads:[~2015-05-03 19:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-01  9:14 [U-Boot] [PATCH] u-boot: adjust config_cmd_default.h not to raise ton of warnings Pavel Machek
2015-05-01 15:24 ` Stephen Warren
2015-05-03 10:01   ` Pavel Machek
2015-05-03 16:40     ` Stephen Warren
2015-05-03 19:33       ` Pavel Machek [this message]
2015-05-15  8:36 ` Pavel Machek
2015-05-15  9:12   ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150503193329.GA17791@amd \
    --to=pavel@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox