From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Date: Sun, 10 May 2015 11:07:38 +0200 Subject: [U-Boot] [PATCH] mtd: sf: Add CONFIG_SPI_N25Q256A_RESET for software-reset In-Reply-To: <201505011926.34941.marex@denx.de> References: <1412176391-24475-1-git-send-email-sr@denx.de> <201505011624.45335.marex@denx.de> <20150501144937.GA16957@amd> <201505011926.34941.marex@denx.de> Message-ID: <20150510090738.GA29448@amd> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri 2015-05-01 19:26:34, Marek Vasut wrote: > On Friday, May 01, 2015 at 04:49:37 PM, Pavel Machek wrote: > > On Fri 2015-05-01 16:24:45, Marek Vasut wrote: > > > On Friday, May 01, 2015 at 11:01:09 AM, Pavel Machek wrote: > > > > diff --git a/drivers/mtd/spi/sf_probe.c b/drivers/mtd/spi/sf_probe.c > > > > index 201471c..f7cfbd9 100644 > > > > --- a/drivers/mtd/spi/sf_probe.c > > > > +++ b/drivers/mtd/spi/sf_probe.c > > > > @@ -347,6 +348,36 @@ int spi_flash_probe_slave(struct spi_slave *spi, > > > > struct spi_flash *flash) } > > > > > > > > } > > > > > > > > +#ifdef CONFIG_SPI_N25Q256A_RESET > > > > > > Should be CONFIG_SPI_MICRON_RESET, since other parts which can also be > > > used would have similar issue. > > > > I'm pretty sure some Micron parts use different interface. > > Which ones ? N25Q128? > > > It'd be nice if you > > > added diffstat into your patches as it makes things easier during > > > review. > > > > Yes, it also makes patch harder to create (as it is tricky to > > hand-edit the patches) > > git format-patch automatically inserts the diffstat for you. As I have already told you, I'm not using git to submit my patches. > > , and having diffstat for a patch that fits on a > > screen is just stupid. > > It's a 2-line diffstat for this patch. If you get a 1-screen big > diffstat, then your patch is most likely wrong. As I said, diffstat for patch that fits on screen is useless and stupid. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html