From: Pavel Machek <pavel@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCHv3] mtd: sf: Add CONFIG_SPI_N25Q256A_RESET for software-reset
Date: Mon, 11 May 2015 10:29:12 +0200 [thread overview]
Message-ID: <20150511082912.GB5127@amd> (raw)
In-Reply-To: <CAD6G_RR2bVYessDRkLyJkgnbqiAkLjJ1ff2_oLLyrx7pkbzceg@mail.gmail.com>
On Mon 2015-05-11 13:35:04, Jagan Teki wrote:
> On 11 May 2015 at 13:18, Marek Vasut <marex@denx.de> wrote:
> > On Sunday, May 10, 2015 at 07:53:46 PM, Pavel Machek wrote:
> >
> > [...]
> >
> >> > As per my early comments on this thread, I'm not happy with this approach
> >> > of being added flash specific in generic code by simply added like this.
> >> >
> >> > I encounter similar issue before and I simply reverted [1]
> >> > http://git.denx.de/?p=u-boot.git;a=commit;h=122d805fd4bd478bb83536348291d
> >> > 34ae648364b
> >> >
> >> > Please think in a different perceptive like adding any flags to specific
> >> > vendor with specific part, but that also require proper tested.
> >>
> >> Ok, could you explain how you'd like to have it solved? Should we just
> >> call spi_flash_cmd() from socfpga-specific code?
> >>
> >> But I'm pretty sure similar issue will be encountered on different
> >> boards, so it would be good to have it in shared place. Do you want me
> >> to create sf_probe_micron and move it there?
> >
> > I'd just add a flag into the SPI NOR table and in the code, I'd check
> > if the flag is set and if so, trigger the Micron-specific code. That
> > ought to be simple and it doesn't introduce any new config options.
>
> Ok, solutions - what about Linux same issue or this requirement should be only
> for u-boot or bootloaders?
Linux probably has same issue.
Do you like Marek's "add a flag to table" proposal?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2015-05-11 8:29 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 15:13 [U-Boot] [PATCH 0/2 v3] arm: socfpga: Add Cadence QSPI support Stefan Roese
2014-10-01 15:13 ` [U-Boot] [PATCH 1/4 v3] spi: Add Cadence QSPI driver used by SoCFPGA Stefan Roese
2014-10-01 15:13 ` [U-Boot] [PATCH 2/4 v3] arm: socfpga: Add Cadence QSPI support to config header Stefan Roese
2014-10-01 15:13 ` [U-Boot] [PATCH 3/4 v3] arm: socfpga: Don't define CONFIG_SPI_FLASH_QUAD Stefan Roese
2014-10-01 15:13 ` [U-Boot] [RFC PATCH 4/4 v3] mtd: sf: Add CONFIG_SPI_N25Q256A_RESET for software-reset Stefan Roese
2014-10-01 18:25 ` Marek Vasut
2014-10-01 18:57 ` Stefan Roese
2014-10-01 19:04 ` Jagan Teki
2014-10-01 19:25 ` Stefan Roese
2014-10-01 23:07 ` Pavel Machek
2014-10-02 6:13 ` Stefan Roese
2014-10-02 2:47 ` Marek Vasut
2014-10-02 8:40 ` Pavel Machek
2014-10-02 11:23 ` Marek Vasut
2015-04-25 19:48 ` Pavel Machek
2015-04-27 16:35 ` Marek Vasut
2015-05-01 9:01 ` [U-Boot] [PATCH] " Pavel Machek
2015-05-01 14:24 ` Marek Vasut
2015-05-01 14:49 ` Pavel Machek
2015-05-01 17:26 ` Marek Vasut
2015-05-10 9:07 ` Pavel Machek
2015-05-10 9:15 ` [U-Boot] [PATCHv2] " Pavel Machek
2015-05-10 9:48 ` Marek Vasut
2015-05-10 10:49 ` [U-Boot] [PATCHv3] " Pavel Machek
2015-05-10 12:24 ` Jagan Teki
2015-05-10 16:25 ` Marek Vasut
2015-05-10 17:43 ` Pavel Machek
2015-05-11 7:47 ` Marek Vasut
2015-05-10 17:53 ` Pavel Machek
2015-05-11 7:48 ` Marek Vasut
2015-05-11 8:05 ` Jagan Teki
2015-05-11 8:29 ` Pavel Machek [this message]
2015-05-11 8:33 ` Jagan Teki
2015-05-11 8:39 ` Pavel Machek
2015-05-11 8:44 ` Jagan Teki
2015-05-11 8:50 ` Pavel Machek
2015-05-11 9:05 ` Jagan Teki
2015-05-11 9:56 ` Pavel Machek
2015-05-11 10:03 ` Jagan Teki
2015-05-15 8:47 ` Pavel Machek
2015-05-15 9:36 ` Marek Vasut
2015-05-15 9:55 ` Pavel Machek
2015-05-10 9:48 ` [U-Boot] [PATCH] " Marek Vasut
2015-04-25 19:44 ` [U-Boot] [RFC PATCH 4/4 v3] " Pavel Machek
2014-10-01 18:43 ` Jagan Teki
2014-10-03 20:58 ` [U-Boot] [PATCH 0/2 v3] arm: socfpga: Add Cadence QSPI support Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150511082912.GB5127@amd \
--to=pavel@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox