From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/4] usb: ohci: Do not reuse ed for interrupt endpoints of different devices
Date: Mon, 11 May 2015 21:17:23 +0200 [thread overview]
Message-ID: <201505112117.23563.marex@denx.de> (raw)
In-Reply-To: <1431371289-17175-2-git-send-email-hdegoede@redhat.com>
On Monday, May 11, 2015 at 09:08:06 PM, Hans de Goede wrote:
> When submitting interrupt packets to an endpoint we only link in the ed
> once to avoid some races surrounding unlinking of periodic endpoints,
> but we share one ohci_device struct / one set of ed-s for all devices,
> which means that if we have an interrupt endpoint at endpoint 1 with one
> device, and a non interrupt endpoint 1 with another device we end up
> with the same ed linked into both the periodic and async lists, which is
> not good (tm).
>
> This commit switches over to using separate ohci_device structs, and thus
> separate ed-s for devices with interrupt endpoints, fixing this.
>
> This fixes e.g. matching a usb storage device and keyboard on the same
> usb-1 hub not working.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Marek Vasut <marex@denx.de>
Best regards,
Marek Vasut
next prev parent reply other threads:[~2015-05-11 19:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 19:08 [U-Boot] [PATCH 0/4] usb: ohci: Add support for interrupt queues Hans de Goede
2015-05-11 19:08 ` [U-Boot] [PATCH 1/4] usb: ohci: Do not reuse ed for interrupt endpoints of different devices Hans de Goede
2015-05-11 19:17 ` Marek Vasut [this message]
2015-05-11 19:08 ` [U-Boot] [PATCH 2/4] usb: ohci: Add an ohci_alloc_urb() function Hans de Goede
2015-05-11 19:18 ` Marek Vasut
2015-05-11 19:08 ` [U-Boot] [PATCH 3/4] usb: ohci: Add support for interrupt queues Hans de Goede
2015-05-11 19:18 ` Marek Vasut
2015-05-11 19:08 ` [U-Boot] [PATCH 4/4] sunxi: Change usb-kbd interrupt polling to use an usb interrupt qeueue Hans de Goede
2015-05-11 19:17 ` Ian Campbell
2015-05-11 19:19 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201505112117.23563.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox