From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Mon, 11 May 2015 21:17:23 +0200 Subject: [U-Boot] [PATCH 1/4] usb: ohci: Do not reuse ed for interrupt endpoints of different devices In-Reply-To: <1431371289-17175-2-git-send-email-hdegoede@redhat.com> References: <1431371289-17175-1-git-send-email-hdegoede@redhat.com> <1431371289-17175-2-git-send-email-hdegoede@redhat.com> Message-ID: <201505112117.23563.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Monday, May 11, 2015 at 09:08:06 PM, Hans de Goede wrote: > When submitting interrupt packets to an endpoint we only link in the ed > once to avoid some races surrounding unlinking of periodic endpoints, > but we share one ohci_device struct / one set of ed-s for all devices, > which means that if we have an interrupt endpoint at endpoint 1 with one > device, and a non interrupt endpoint 1 with another device we end up > with the same ed linked into both the periodic and async lists, which is > not good (tm). > > This commit switches over to using separate ohci_device structs, and thus > separate ed-s for devices with interrupt endpoints, fixing this. > > This fixes e.g. matching a usb storage device and keyboard on the same > usb-1 hub not working. > > Signed-off-by: Hans de Goede Reviewed-by: Marek Vasut Best regards, Marek Vasut