[U-Boot] mxs: Possible in bug in mxs_enable_4p2_dcdc_input

Marek Vasut
2015-05-13T07:13:25Z

On Wednesday, May 13, 2015 at 08:02:21 AM, Stefan Wahren wrote:
> Hi,

Hi,

> during the study of DC-DC handling in u-boot i noticed a possible bug.
>
> In case the DC-DC is already enabled the function returns without
> reenabling brown out detection. I don't think that's okay.
> A possible fix would be to do the check if DC-DC is already enabled before
> disabling brown out detection. This idea is
> attached as a draft. If it's acceptable i will send a proper patch.

What exactly would happen if you enable DCDC converter while BO detection
is already enabled ? It is possible, that enabling the DCDC would cause a
dip on the power rail and cause in turn a BO, no ? IIRC, that is the reason
why BO detection is disabled when enabling DCDC.

Best regards,
Marek Vasut