From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] imx: dma: correct MXS_DMA_ALIGNMENT
Date: Thu, 21 May 2015 03:26:04 +0200 [thread overview]
Message-ID: <201505210326.04148.marex@denx.de> (raw)
In-Reply-To: <20150521011629.GA25156@shlinux2>
On Thursday, May 21, 2015 at 03:16:32 AM, Peng Fan wrote:
> Hi Marek,
Hi!
> On Wed, May 20, 2015 at 01:06:21PM +0200, Marek Vasut wrote:
> >On Wednesday, May 20, 2015 at 04:28:48 AM, Peng Fan wrote:
> >> We should not hardcode MXS_DMA_ALIGNMENT to 32, since we can not
> >> guarantee that socs' cache line size is 32 bytes.
> >
> >> If on chips whose cache line size is 64 bytes, error occurs:
> >Which chips are those?
>
> i.MX7's L1 Cache line size is 64 bytes.
Oh, I didn't know this was a public info. Oki, thanks for clarifying :)
> >> NAND: ERROR: v7_dcache_inval_range - start address is not aligned -
> >> 0xbdf1d1a0 ERROR: v7_dcache_inval_range - stop address is not aligned -
> >> 0xbdf1f4a0 ERROR: v7_dcache_inval_range - start address is not aligned -
> >> 0xbdf1d1a0 "
> >> Align MXS_DMA_ALIGNMENT with ARCH_DMA_MINALIGN whose value is same to
> >> CONFIG_SYS_CACHELINE_SIZE if CONFIG_SYS_CACHELINE_SIZE defined.
> >>
> >> Signed-off-by: Peng Fan <Peng.Fan@freescale.com>
> >
> >Acked-by: Marek Vasut <marex@denx.de>
> >
> >Best regards,
> >Marek Vasut
>
> Regards,
> Peng.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2015-05-21 1:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 2:28 [U-Boot] [PATCH] imx: dma: correct MXS_DMA_ALIGNMENT Peng Fan
2015-05-20 11:06 ` Marek Vasut
2015-05-21 1:16 ` Peng Fan
2015-05-21 1:26 ` Marek Vasut [this message]
2015-05-25 13:08 ` Peng Fan
2015-05-26 12:16 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201505210326.04148.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox