public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb: imx: Allow multiple USB ports to be used at the same time on mx5
Date: Fri, 22 May 2015 01:09:13 +0200	[thread overview]
Message-ID: <201505220109.13537.marex@denx.de> (raw)
In-Reply-To: <64CA5C49A43E314D9F7DAE05370E2F7B05F54E63@hed-dc01.hed.local>

On Thursday, May 21, 2015 at 11:02:55 PM, Matthew Starr wrote:
> CONFIG_MXC_USB_PORT was used to define which USB port was to be
> initialized.  If CONFIG_USB_MAX_CONTROLLER_COUNT > 1, then the
> port specified by CONFIG_MXC_USB_PORT would be duplicated
> CONFIG_USB_MAX_CONTROLLER_COUNT times including duplicating all
> devices connected to the ports.  None of the other USB ports would
> be available for use.
> 
> The fix is to remove all instances of CONFIG_MXC_USB_PORT from the
> imx53 ehci driver since it was only allowing the port specified by
> CONFIG_MXC_USB_PORT to be populated.  Then use
> CONFIG_USB_MAX_CONTROLLER_COUNT to specifiy which USB ports should be
> enabled, starting with port 0.  If port 1 is needed, then set
> CONFIG_USB_MAX_CONTROLLER_COUNT to 2 so 2 ports get populated (port 0
> and port 1) even though port 0 will not be used.
> 
> Configurations for all boards affected are updated.
> 
> Signed-off-by: Matthew Starr <mstarr@hedonline.com>

Hi! Why don't you just define a list of controllers which should be
initialized instead ?

#define CONTROLLERS_TO_INIT { USB1, USB3 }

Where USB1 and USB3 is the address of the controller. Note that these
addresses are defined in arch/arm/include/ headers.

Best regards,
Marek Vasut

      parent reply	other threads:[~2015-05-21 23:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1432242175-11817-1-git-send-email-mstarr@hedonline.com>
2015-05-21 21:02 ` [U-Boot] [PATCH] usb: imx: Allow multiple USB ports to be used at the same time on mx5 Matthew Starr
2015-05-21 21:06   ` Simon Glass
2015-05-21 21:13     ` Matthew Starr
2015-05-21 21:19       ` Simon Glass
2015-05-21 23:09   ` Marek Vasut [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201505220109.13537.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox