* [U-Boot] [PATCH][v2] drivers: usb: fsl: Return if USB_MAX_CONTROLLER_COUNT is incorrect
@ 2015-06-07 6:58 Nikhil Badola
2015-06-07 13:45 ` Marek Vasut
0 siblings, 1 reply; 2+ messages in thread
From: Nikhil Badola @ 2015-06-07 6:58 UTC (permalink / raw)
To: u-boot
Return if USB_MAX_CONTROLLER_COUNT hence the index of the controller
to be initialised is incorrect
Signed-off-by: Nikhil Badola <nikhil.badola@freescale.com>
---
Changes for v2
- Added space between tags in Subject
- Replaced return value from -1 to -EINVAL
drivers/usb/host/ehci-fsl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c
index 5fd618d..97b7f14 100644
--- a/drivers/usb/host/ehci-fsl.c
+++ b/drivers/usb/host/ehci-fsl.c
@@ -76,7 +76,7 @@ int ehci_hcd_init(int index, enum usb_init_type init,
break;
default:
printf("ERROR: wrong controller index!!\n");
- break;
+ return -EINVAL;
};
*hccr = (struct ehci_hccr *)((uint32_t)&ehci->caplength);
--
1.7.11.7
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] [PATCH][v2] drivers: usb: fsl: Return if USB_MAX_CONTROLLER_COUNT is incorrect
2015-06-07 6:58 [U-Boot] [PATCH][v2] drivers: usb: fsl: Return if USB_MAX_CONTROLLER_COUNT is incorrect Nikhil Badola
@ 2015-06-07 13:45 ` Marek Vasut
0 siblings, 0 replies; 2+ messages in thread
From: Marek Vasut @ 2015-06-07 13:45 UTC (permalink / raw)
To: u-boot
On Sunday, June 07, 2015 at 08:58:04 AM, Nikhil Badola wrote:
> Return if USB_MAX_CONTROLLER_COUNT hence the index of the controller
> to be initialised is incorrect
This text doesn't really make much sense, but the fix is reasonable.
I'll pick it, thanks!
> Signed-off-by: Nikhil Badola <nikhil.badola@freescale.com>
> ---
> Changes for v2
> - Added space between tags in Subject
> - Replaced return value from -1 to -EINVAL
>
> drivers/usb/host/ehci-fsl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c
> index 5fd618d..97b7f14 100644
> --- a/drivers/usb/host/ehci-fsl.c
> +++ b/drivers/usb/host/ehci-fsl.c
> @@ -76,7 +76,7 @@ int ehci_hcd_init(int index, enum usb_init_type init,
> break;
> default:
> printf("ERROR: wrong controller index!!\n");
> - break;
> + return -EINVAL;
> };
>
> *hccr = (struct ehci_hccr *)((uint32_t)&ehci->caplength);
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-06-07 13:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-07 6:58 [U-Boot] [PATCH][v2] drivers: usb: fsl: Return if USB_MAX_CONTROLLER_COUNT is incorrect Nikhil Badola
2015-06-07 13:45 ` Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox