From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Sun, 7 Jun 2015 15:45:47 +0200
Subject: [U-Boot] [PATCH][v2] drivers: usb: fsl: Return if
	USB_MAX_CONTROLLER_COUNT is incorrect
In-Reply-To: <1433660284-10477-1-git-send-email-nikhil.badola@freescale.com>
References: <1433660284-10477-1-git-send-email-nikhil.badola@freescale.com>
Message-ID: <201506071545.48042.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Sunday, June 07, 2015 at 08:58:04 AM, Nikhil Badola wrote:
> Return if USB_MAX_CONTROLLER_COUNT hence the index of the controller
> to be initialised is incorrect

This text doesn't really make much sense, but the fix is reasonable.
I'll pick it, thanks!

> Signed-off-by: Nikhil Badola <nikhil.badola@freescale.com>
> ---
> Changes for v2
> 	- Added space between tags in Subject
> 	- Replaced return value from -1 to -EINVAL
> 
>  drivers/usb/host/ehci-fsl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c
> index 5fd618d..97b7f14 100644
> --- a/drivers/usb/host/ehci-fsl.c
> +++ b/drivers/usb/host/ehci-fsl.c
> @@ -76,7 +76,7 @@ int ehci_hcd_init(int index, enum usb_init_type init,
>  		break;
>  	default:
>  		printf("ERROR: wrong controller index!!\n");
> -		break;
> +		return -EINVAL;
>  	};
> 
>  	*hccr = (struct ehci_hccr *)((uint32_t)&ehci->caplength);

Best regards,
Marek Vasut