From: Lukasz Majewski <l.majewski@majess.pl>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fastboot: Dynamic controller index for usb_gadget_handle_interrupts
Date: Sun, 7 Jun 2015 22:48:55 +0200 [thread overview]
Message-ID: <20150607224855.59c22918@jawa> (raw)
In-Reply-To: <CAPnjgZ29xYftfwshhSsaojETWzsc2s=3dBZCus8MrmKuKW8tHA@mail.gmail.com>
On Sun, 7 Jun 2015 08:48:31 -0600
Simon Glass <sjg@chromium.org> wrote:
> On 25 May 2015 at 08:50, Lukasz Majewski <l.majewski@samsung.com>
> wrote:
> > Hi Paul,
> >
> >> Since we're now using a dynamic controller index for fastboot too,
> >> usb_gadget_handle_interrupts should be using it instead of 0
> >> (despite the fact that it's currently not being used at all in the
> >> musb-new implementation).
> >>
> >> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> >> ---
> >> common/cmd_fastboot.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/common/cmd_fastboot.c b/common/cmd_fastboot.c
> >> index 86fbddf..b9d1c8c 100644
> >> --- a/common/cmd_fastboot.c
> >> +++ b/common/cmd_fastboot.c
> >> @@ -47,7 +47,7 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int
> >> flag, int argc, char *const argv[]) break;
> >> if (ctrlc())
> >> break;
> >> - usb_gadget_handle_interrupts(0);
> >> + usb_gadget_handle_interrupts(controller_index);
> >> }
> >>
> >> ret = CMD_RET_SUCCESS;
> >
> > Reviewed-by: Lukasz Majewski <l.majewski@samsung.com>
>
> This is in my queue and looks like a fix, so I'm picking it up.
>
> Applied to u-boot-x86, thanks!
One less to go ;-).
Thanks Simon.
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150607/78a54f3b/attachment.sig>
next prev parent reply other threads:[~2015-06-07 20:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-24 9:41 [U-Boot] [PATCH] fastboot: Dynamic controller index for usb_gadget_handle_interrupts Paul Kocialkowski
2015-05-25 14:50 ` Lukasz Majewski
2015-06-07 14:48 ` Simon Glass
2015-06-07 20:48 ` Lukasz Majewski [this message]
2015-06-12 21:23 ` Simon Glass
2015-06-13 7:27 ` Paul Kocialkowski
2015-07-07 12:29 ` Paul Kocialkowski
2015-07-14 12:38 ` Paul Kocialkowski
2015-07-14 15:22 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150607224855.59c22918@jawa \
--to=l.majewski@majess.pl \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox