From: "Pali Rohár" <pali.rohar@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] U-Boot: Nokia N900 (RX-51) is broken again
Date: Tue, 9 Jun 2015 18:23:46 +0200 [thread overview]
Message-ID: <201506091823.46395@pali> (raw)
Hello,
commit e11c6c279d823dc0d2f470c5c2e3c0a9854a640f
Author: Simon Glass <sjg@chromium.org>
Date: Sat Feb 7 10:47:28 2015 -0700
arm: Allow lr to be saved by board code
The link register value can be required on some boards (e.g. FEL mode on
sunxi) so use a branch instruction to jump to save_boot_params() instead
of a branch link.
This requires a branch back to save_boot_params_ret so adjust the users
to deal with this. For exynos just drop the function since it doesn't
do anything.
Signed-off-by: Simon Glass <sjg@chromium.org>
Acked-by: Siarhei Siamashka <siarhei.siamashka@gmail.com>
Acked-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
This commit broke Nokia N900 board support. When I tried it to boot in
qemu I just get this qemu error message:
qemu: fatal: Trying to execute code outside RAM or ROM at 0x7fb0fdfc
R00=806ffd08 R01=80207800 R02=80207800 R03=00000000
R04=00000000 R05=00000000 R06=00000000 R07=00000000
R08=00000000 R09=00000000 R10=00000000 R11=00000000
R12=80000414 R13=804ffb90 R14=7fb0fdfc R15=7fb0fdfc
PSR=600001df -ZC- A sys32
Aborted
U-Boot compiled before above commit working in qemu fine.
When I revert commits 5519912164698b634893913b4408fee736d01d06 and
e11c6c279d823dc0d2f470c5c2e3c0a9854a640f on top of master, then u-boot
from master working fine on Nokia N900.
Can you fix broken commit? Because now U-Boot for Nokia N900 board is
not working...
Thanks.
--
Pali Roh?r
pali.rohar at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150609/cc305bcf/attachment.sig>
next reply other threads:[~2015-06-09 16:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-09 16:23 Pali Rohár [this message]
2015-06-09 17:05 ` [U-Boot] [PATCH] Nokia RX-51: Fix calculating return address in save_boot_params Pali Rohár
2015-06-09 18:11 ` Simon Glass
2015-06-09 18:27 ` Pali Rohár
2015-06-11 0:50 ` Simon Glass
2015-06-12 11:00 ` Pali Rohár
2015-06-12 12:12 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201506091823.46395@pali \
--to=pali.rohar@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox