From: "Pali Rohár" <pali.rohar@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Nokia RX-51: Fix calculating return address in save_boot_params
Date: Tue, 9 Jun 2015 20:27:19 +0200 [thread overview]
Message-ID: <201506092027.19980@pali> (raw)
In-Reply-To: <CAPnjgZ3ktAoFmT8wvEdn2nf_5+1kEMC+=kOjbm87Tj2=jsq7xA@mail.gmail.com>
On Tuesday 09 June 2015 20:11:22 Simon Glass wrote:
> On 9 June 2015 at 10:05, Pali Roh?r <pali.rohar@gmail.com> wrote:
> > Commit e11c6c279d823dc0d2f470c5c2e3c0a9854a640f broke calculating
> > lr register in function save_boot_params() and caused U-Boot to
> > crash at early boot time on Nokia N900 board.
> >
> > This patch fix calculating return address in lr register and make
> > Nokia N900 board bootable again. Patch was tested in qemu and also
> > on real N900 HW.
> >
> > Signed-off-by: Pali Roh?r <pali.rohar@gmail.com>
> > ---
> >
> > board/nokia/rx51/lowlevel_init.S | 4 ----
> > 1 file changed, 4 deletions(-)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Tom, can you please apply this patch for 2015.07?
Simon & others: in future, please can you CC me all patches which touch
Nokia N900 board code? We can prevent such breakage. Also you can test
u-boot for n900 in qemu.
--
Pali Roh?r
pali.rohar at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150609/9d54c170/attachment.sig>
next prev parent reply other threads:[~2015-06-09 18:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-09 16:23 [U-Boot] U-Boot: Nokia N900 (RX-51) is broken again Pali Rohár
2015-06-09 17:05 ` [U-Boot] [PATCH] Nokia RX-51: Fix calculating return address in save_boot_params Pali Rohár
2015-06-09 18:11 ` Simon Glass
2015-06-09 18:27 ` Pali Rohár [this message]
2015-06-11 0:50 ` Simon Glass
2015-06-12 11:00 ` Pali Rohár
2015-06-12 12:12 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201506092027.19980@pali \
--to=pali.rohar@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox