[U-Boot] [PATCH 1/4] usb: USB download gadget and functions config options coherent naming

Lukasz Majewski
2015-06-12T20:06:14Z

On Fri, 12 Jun 2015 19:59:22 +0200
Paul Kocialkowski <contact@paulk.fr> wrote:

> Le vendredi 12 juin 2015 ? 16:10 +0200, Lukasz Majewski a ?crit :
> > Hi Paul,
> >
> > > Le lundi 18 mai 2015 ? 15:01 +0200, Lukasz Majewski a ?crit :
> > > > Hi Paul,
> > > >
> > > > > This introduces a coherent scheme for naming USB download
> > > > > gadget and functions config options. The download USB gadget
> > > > > config option is moved to CONFIG_USB_GADGET_DOWNLOAD for
> > > > > better consistency with other gadgets and each function's
> > > > > config option is moved to a CONFIG_USB_FUNCTION_ prefix.
> > > > >
> > > > > Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> > > > > ---
> > >
> > > [snip]
> > >
> > > > Acked-by: Lukasz Majewski <l.majewski@samsung.com>
> > > >
> > > > I will test this patch on my devices and then pull it to
> > > > u-boot-dfu tree.
> > >
> > > Is there anything holding back this patch set at this point?
> > >
> >
> > Sorry to say, but:
> >
> > ./tools/buildman/buildman.py --branch=HEAD samsung --detail
> > --verbose --show_errors --force-build --count=4
> > --output-dir=./BUILD/
> >
> > run on top of the newest u-boot-denx-usb/master
> >
> > SHA1: b2d0495b16e9e2fdaa1c04f5a43bf60f4ad3a5ea
> >
> > Caused build errors on the Odroix-XU3 board (attached to this
> > e-mail).
>
> Heh, I guess the patches were just too old. I just sent out v2 that
> includes the Odroid XU3.

Thanks :-).

One more thing - in the future please add me to CC (as you didn't do
that for v2).

In u-boot you can use ./tools/patman tool to generate list of e-mail
receivers.

>
> Thanks for pointing this out.
>

No problem :-). You were first "victim" of my automated building and
testing setup :-).

Best regards,
?ukasz Majewski
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150612/f7ef3648/attachment.sig>