From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Mon, 15 Jun 2015 11:32:13 -0400 Subject: [U-Boot] [PATCH 1/4] spl, common, serial: build SPL without serial support In-Reply-To: <1434370862-8203-2-git-send-email-hs@denx.de> References: <1434370862-8203-1-git-send-email-hs@denx.de> <1434370862-8203-2-git-send-email-hs@denx.de> Message-ID: <20150615153213.GX1728@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Jun 15, 2015 at 02:20:59PM +0200, Heiko Schocher wrote: > This patch enables building SPL without > CONFIG_SPL_SERIAL_SUPPORT support. > > Signed-off-by: Heiko Schocher I like that we're starting down this path. But can you explain why we need each of these changes: > arch/arm/lib/interrupts.c | 4 ++-- > arch/arm/mach-at91/arm926ejs/cpu.c | 2 +- > common/cli_readline.c | 2 +- > common/cli_simple.c | 2 +- > lib/display_options.c | 4 ++-- Having gone down the path of disabling output in SPL before due to size constraints I didn't need to modify those files (but it was on an older version) > common/image.c | 8 ++++++-- In this case I just said we only need those functions (and their strings!) when we have SPL_SERIAL available. It may be worth re-checking what parts of this file we really need available in SPL even. > common/spl/spl.c | 9 +++++++++ We should be able to be fine without a preloader_console_init() func I think. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: