[U-Boot] [PATCH 3/4] ARM: mmc: bcm283x: Remove get_timer_us() from mmc driver

Marek Vasut
2015-06-19T21:39:02Z

On Thursday, June 18, 2015 at 02:51:18 PM, Jakub Kici?ski wrote:
> On Thu, 18 Jun 2015 14:35:27 +0200, Marek Vasut wrote:
> > On Wednesday, June 17, 2015 at 06:13:03 PM, Jakub Kici?ski wrote:
> > > On Wed, 17 Jun 2015 12:44:15 +0200, Marek Vasut wrote:
> > > > On Tuesday, June 16, 2015 at 05:44:06 AM, Stephen Warren wrote:
> > > > > On 05/04/2015 02:54 PM, Marek Vasut wrote:
> > > > > > The get_timer_us() function is something which is no longer
> > > > > > existing in case we use generic timer framework, so replace
> > > > > > it with get_timer().
> > > > >
> > > > > Marek,
> > > > >
> > > > > This patch causes "saveenv" to got from almost no time to nearly
> > > > > 50s on my RPi model A+. Can you take a look at that please?
> > > >
> > > > Can you try the attached diff ? ;-/ I think I mistakenly used
> > > > get_timer(), which returns msecs instead of timer_get_us() which
> > > > reports usecs, sorry.
> > >
> > > I can confirm this solves the regression.
> >
> > That's not a regression, that was a bug ;-)
>
> Ach OK, I thought Stephen said that MMC used to be fast before the
> offending patch ;) Anyway I don't really know what's the difference
> and wikipedia says regression is a bug too so we may both be right :P

I always considered it to be [1] 2c , maybe I'm wrong though ;-)
Just recently I thought I finally figured out the difference too,
but now you surely made me unsure again :)

"
2 : a trend or shift toward a lower or less perfect state: as
c : reversion to an earlier mental or behavioral level
"

[1] http://www.merriam-webster.com/dictionary/regression

Best regards,
Marek Vasut