From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub =?UTF-8?B?S2ljacWEc2tp?= Date: Thu, 18 Jun 2015 14:51:18 +0200 Subject: [U-Boot] [PATCH 3/4] ARM: mmc: bcm283x: Remove get_timer_us() from mmc driver In-Reply-To: <201506181435.28083.marex@denx.de> References: <1430772877-7301-1-git-send-email-marex@denx.de> <201506171244.15801.marex@denx.de> <20150617181303.18366ab9@north> <201506181435.28083.marex@denx.de> Message-ID: <20150618145118.18d20792@north> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, 18 Jun 2015 14:35:27 +0200, Marek Vasut wrote: > On Wednesday, June 17, 2015 at 06:13:03 PM, Jakub Kici?ski wrote: > > On Wed, 17 Jun 2015 12:44:15 +0200, Marek Vasut wrote: > > > On Tuesday, June 16, 2015 at 05:44:06 AM, Stephen Warren wrote: > > > > On 05/04/2015 02:54 PM, Marek Vasut wrote: > > > > > The get_timer_us() function is something which is no longer > > > > > existing in case we use generic timer framework, so replace > > > > > it with get_timer(). > > > > > > > > Marek, > > > > > > > > This patch causes "saveenv" to got from almost no time to nearly 50s on > > > > my RPi model A+. Can you take a look at that please? > > > > > > Can you try the attached diff ? ;-/ I think I mistakenly used > > > get_timer(), which returns msecs instead of timer_get_us() which reports > > > usecs, sorry. > > > > I can confirm this solves the regression. > > That's not a regression, that was a bug ;-) Ach OK, I thought Stephen said that MMC used to be fast before the offending patch ;) Anyway I don't really know what's the difference and wikipedia says regression is a bug too so we may both be right :P