public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/4] ARM: mmc: bcm283x: Remove get_timer_us() from mmc driver
Date: Fri, 19 Jun 2015 23:39:02 +0200	[thread overview]
Message-ID: <201506192339.02631.marex@denx.de> (raw)
In-Reply-To: <20150618145118.18d20792@north>

On Thursday, June 18, 2015 at 02:51:18 PM, Jakub Kici?ski wrote:
> On Thu, 18 Jun 2015 14:35:27 +0200, Marek Vasut wrote:
> > On Wednesday, June 17, 2015 at 06:13:03 PM, Jakub Kici?ski wrote:
> > > On Wed, 17 Jun 2015 12:44:15 +0200, Marek Vasut wrote:
> > > > On Tuesday, June 16, 2015 at 05:44:06 AM, Stephen Warren wrote:
> > > > > On 05/04/2015 02:54 PM, Marek Vasut wrote:
> > > > > > The get_timer_us() function is something which is no longer
> > > > > > existing in case we use generic timer framework, so replace
> > > > > > it with get_timer().
> > > > > 
> > > > > Marek,
> > > > > 
> > > > > This patch causes "saveenv" to got from almost no time to nearly
> > > > > 50s on my RPi model A+. Can you take a look at that please?
> > > > 
> > > > Can you try the attached diff ? ;-/ I think I mistakenly used
> > > > get_timer(), which returns msecs instead of timer_get_us() which
> > > > reports usecs, sorry.
> > > 
> > > I can confirm this solves the regression.
> > 
> > That's not a regression, that was a bug ;-)
> 
> Ach OK, I thought Stephen said that MMC used to be fast before the
> offending patch ;)  Anyway I don't really know what's the difference
> and wikipedia says regression is a bug too so we may both be right :P

I always considered it to be [1] 2c , maybe I'm wrong though ;-)
Just recently I thought I finally figured out the difference too,
but now you surely made me unsure again :)

"
2 :  a trend or shift toward a lower or less perfect state: as 
  c :  reversion to an earlier mental or behavioral level 
"

[1] http://www.merriam-webster.com/dictionary/regression

Best regards,
Marek Vasut

  reply	other threads:[~2015-06-19 21:39 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-04 20:54 [U-Boot] [PATCH 1/4] ARM: bcm283x: Repair wdog.h Marek Vasut
2015-05-04 20:54 ` [U-Boot] [PATCH 2/4] ARM: bcm283x: Reorder timer.h Marek Vasut
2015-05-28 13:25   ` [U-Boot] [U-Boot,2/4] " Tom Rini
2015-05-04 20:54 ` [U-Boot] [PATCH 3/4] ARM: mmc: bcm283x: Remove get_timer_us() from mmc driver Marek Vasut
2015-05-05  9:40   ` Pantelis Antoniou
2015-06-16  3:44   ` Stephen Warren
2015-06-17 10:44     ` Marek Vasut
2015-06-17 16:13       ` Jakub Kiciński
2015-06-18 12:35         ` Marek Vasut
2015-06-18 12:51           ` Jakub Kiciński
2015-06-19 21:39             ` Marek Vasut [this message]
2015-06-18  1:55       ` Stephen Warren
2015-05-04 20:54 ` [U-Boot] [PATCH 4/4] ARM: bcm283x: Switch to generic timer Marek Vasut
2015-05-05 21:46   ` Stephen Warren
2015-05-05 22:17     ` Marek Vasut
2015-05-05 22:37       ` Stephen Warren
2015-05-05 22:42         ` Marek Vasut
2015-05-05 22:57           ` Stephen Warren
2015-05-05 23:37             ` Marek Vasut
2015-05-06 15:52               ` Stephen Warren
2015-05-06 18:13                 ` Marek Vasut
2015-05-06 19:51                   ` Tyler Baker
2015-05-08 16:06                     ` Stephen Warren
2015-05-08 16:23                       ` Marek Vasut
2015-05-08 16:03                   ` Stephen Warren
2015-05-08 16:31                     ` Marek Vasut
2015-05-08 16:40                       ` Stephen Warren
2015-05-08 18:20                         ` Marek Vasut
2015-05-28 13:25   ` [U-Boot] [U-Boot,4/4] " Tom Rini
2015-05-28 13:25 ` [U-Boot] [U-Boot,1/4] ARM: bcm283x: Repair wdog.h Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201506192339.02631.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox