From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/5] sunxi: rsb: Enable R_PIO clock before configuring external pins
Date: Tue, 23 Jun 2015 20:29:21 +0200 [thread overview]
Message-ID: <20150623182921.GR2266@lukather> (raw)
In-Reply-To: <1435060647-30648-3-git-send-email-wens@csie.org>
On Tue, Jun 23, 2015 at 07:57:24PM +0800, Chen-Yu Tsai wrote:
> The original code was configuring the external pins after enabling
> the R_PIO clock, which meant the configuration never made it to
> the pin controller the first time in SPL.
>
> Why this was working before is uncertain. Maybe the state was left
> from a previous boot sequence, or RSB just happened to be the default
> configuration. However with some A33 chips, SPL failed to configure
> the PMIC. This was seen by me and Maxime on the Sinlinx SinA33 dev
> board.
>
> Reordering the calls fixed this.
>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Tested-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150623/60c524de/attachment.sig>
next prev parent reply other threads:[~2015-06-23 18:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-23 11:57 [U-Boot] [PATCH 0/5] sunxi: misc fixes and SinA33 support Chen-Yu Tsai
2015-06-23 11:57 ` [U-Boot] [PATCH 1/5] sunxi: hardware-feature-specific function index defines for PORT F UART0 Chen-Yu Tsai
2015-06-23 11:57 ` [U-Boot] [PATCH 2/5] sunxi: rsb: Enable R_PIO clock before configuring external pins Chen-Yu Tsai
2015-06-23 18:29 ` Maxime Ripard [this message]
2015-06-23 11:57 ` [U-Boot] [PATCH 3/5] sunxi: Add support for UART0 in PB pin group on A33 Chen-Yu Tsai
2015-06-23 11:57 ` [U-Boot] [PATCH 4/5] sunxi: Sync sun8i dts files with the linux kernel Chen-Yu Tsai
2015-06-23 11:57 ` [U-Boot] [PATCH 5/5] sunxi: Add Sinlinx SinA33 defconfig Chen-Yu Tsai
2015-06-26 10:14 ` [U-Boot] [PATCH 0/5] sunxi: misc fixes and SinA33 support Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150623182921.GR2266@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox