From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Date: Tue, 23 Jun 2015 20:29:21 +0200 Subject: [U-Boot] [PATCH 2/5] sunxi: rsb: Enable R_PIO clock before configuring external pins In-Reply-To: <1435060647-30648-3-git-send-email-wens@csie.org> References: <1435060647-30648-1-git-send-email-wens@csie.org> <1435060647-30648-3-git-send-email-wens@csie.org> Message-ID: <20150623182921.GR2266@lukather> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Jun 23, 2015 at 07:57:24PM +0800, Chen-Yu Tsai wrote: > The original code was configuring the external pins after enabling > the R_PIO clock, which meant the configuration never made it to > the pin controller the first time in SPL. > > Why this was working before is uncertain. Maybe the state was left > from a previous boot sequence, or RSB just happened to be the default > configuration. However with some A33 chips, SPL failed to configure > the PMIC. This was seen by me and Maxime on the Sinlinx SinA33 dev > board. > > Reordering the calls fixed this. > > Signed-off-by: Chen-Yu Tsai > Cc: Maxime Ripard Tested-by: Maxime Ripard Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: