[U-Boot] corrupted tags in git://git.denx.de/u-boot ?

[Wolfgang Denk <wd@denx.de>]

Dear Igor,

In message <558979E4.9030501@compulab.co.il> you wrote:
> 
> > In other words, I cannot reproduce your issue here.
> 
> May be it has something to do with my git version?
> $ git --version
> git version 2.3.6

I did my tests with:

-> git --version
git version 2.1.0

[This is what Fedora 21 uses.]


In Fedora 22 I get

-> git --version
git version 2.4.2

which then shows:

-> git fsck --full
Checking object directories: 100% (256/256), done.
error in tag eb394f56db3e05d00891d6dc36a00df0025cf255: unterminated header
error in tag 9bf86baaa3b35b25baa2d664e2f7f6cafad689ee: unterminated header
error in tag c7071e6d645a8e13adb0d4cea2caad27213fa62f: unterminated header
Checking objects: 100% (328644/328644), done.
Checking connectivity: 325719, done.


> $ git fsck --full
> Checking object directories: 100% (256/256), done.
> error in tag eb394f56db3e05d00891d6dc36a00df0025cf255: unterminated header
> error in tag 9bf86baaa3b35b25baa2d664e2f7f6cafad689ee: unterminated header
> error in tag c7071e6d645a8e13adb0d4cea2caad27213fa62f: unterminated header
> Checking objects: 100% (325719/325719), done.
> Checking connectivity: 325719, done.

Confirmed.

> It seems that the check for termination with '\n' in tag headers
> started to be a requirement from git version 2.2.0?

I think you are right.  The fact that v2.1.0 does not show anything
but v2.3.6 and v2.4.2 do also supports your analysis.

> This [1] seems to be the patch that triggers the message I see.
> 
> [1] https://github.com/git/git/commit/4d0d89755e82c40df88cf94d84031978f8eac827

Yes, I agree.

So apparently the tags  LABEL_2006_03_12_0025, LABEL_2006_04_18_1106,
and LABEL_2006_05_19_1133 are affected.

IIUC it should be a harmless thing to just recreate the same tags
(referring to the same commits)?  Or can anybody see any problems tha
might be caused by such a tag re-creation?  I mean, it is not like a
rebase of the repository or something like that?  Right?


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
C++ was an interesting and valuable experiment, but we've learned its
lessons and it's time to move on.
                            - Peter Curran in <DCqM4z.BxB@isgtec.com>