From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] corrupted tags in git://git.denx.de/u-boot ?
Date: Thu, 25 Jun 2015 09:27:31 -0400 [thread overview]
Message-ID: <20150625132731.GC28577@bill-the-cat> (raw)
In-Reply-To: <20150625132221.9FD5A38005C@gemini.denx.de>
On Thu, Jun 25, 2015 at 03:22:21PM +0200, Wolfgang Denk wrote:
> Dear Igor,
>
> In message <558979E4.9030501@compulab.co.il> you wrote:
> >
> > > In other words, I cannot reproduce your issue here.
> >
> > May be it has something to do with my git version?
> > $ git --version
> > git version 2.3.6
>
> I did my tests with:
>
> -> git --version
> git version 2.1.0
>
> [This is what Fedora 21 uses.]
>
>
> In Fedora 22 I get
>
> -> git --version
> git version 2.4.2
>
> which then shows:
>
> -> git fsck --full
> Checking object directories: 100% (256/256), done.
> error in tag eb394f56db3e05d00891d6dc36a00df0025cf255: unterminated header
> error in tag 9bf86baaa3b35b25baa2d664e2f7f6cafad689ee: unterminated header
> error in tag c7071e6d645a8e13adb0d4cea2caad27213fa62f: unterminated header
> Checking objects: 100% (328644/328644), done.
> Checking connectivity: 325719, done.
>
>
> > $ git fsck --full
> > Checking object directories: 100% (256/256), done.
> > error in tag eb394f56db3e05d00891d6dc36a00df0025cf255: unterminated header
> > error in tag 9bf86baaa3b35b25baa2d664e2f7f6cafad689ee: unterminated header
> > error in tag c7071e6d645a8e13adb0d4cea2caad27213fa62f: unterminated header
> > Checking objects: 100% (325719/325719), done.
> > Checking connectivity: 325719, done.
>
> Confirmed.
>
> > It seems that the check for termination with '\n' in tag headers
> > started to be a requirement from git version 2.2.0?
>
> I think you are right. The fact that v2.1.0 does not show anything
> but v2.3.6 and v2.4.2 do also supports your analysis.
>
> > This [1] seems to be the patch that triggers the message I see.
> >
> > [1] https://github.com/git/git/commit/4d0d89755e82c40df88cf94d84031978f8eac827
>
> Yes, I agree.
>
> So apparently the tags LABEL_2006_03_12_0025, LABEL_2006_04_18_1106,
> and LABEL_2006_05_19_1133 are affected.
>
> IIUC it should be a harmless thing to just recreate the same tags
> (referring to the same commits)? Or can anybody see any problems tha
> might be caused by such a tag re-creation? I mean, it is not like a
> rebase of the repository or something like that? Right?
Lets take it up on the git list and ask for help/advice?
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150625/05f65b57/attachment.sig>
next prev parent reply other threads:[~2015-06-25 13:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-23 12:13 [U-Boot] corrupted tags in git://git.denx.de/u-boot ? Igor Grinberg
2015-06-23 13:31 ` Wolfgang Denk
2015-06-23 15:23 ` Igor Grinberg
2015-06-25 13:22 ` Wolfgang Denk
2015-06-25 13:27 ` Tom Rini [this message]
2015-06-26 6:12 ` Wolfgang Denk
2015-06-26 2:06 ` Joe Hershberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150625132731.GC28577@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox