From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/2] sunxi: musb: Fix "usb reset" handling
Date: Fri, 26 Jun 2015 12:20:58 +0200 [thread overview]
Message-ID: <20150626102058.GM2266@lukather> (raw)
In-Reply-To: <1434278413-21157-1-git-send-email-hdegoede@redhat.com>
Hi,
On Sun, Jun 14, 2015 at 12:40:11PM +0200, Hans de Goede wrote:
> Paul, can you test these with gadget mode? Specifically if they help the
> problem you were seeing when switching roles?
>
> Also this bit from the kernel code for the sunxi glue may be relevant
> to your problems:
>
> if ((musb->int_usb & MUSB_INTR_RESET) && !is_host_active(musb)) {
> /* ep0 FADDR must be 0 when (re)entering peripheral mode */
> musb_ep_select(musb->mregs, 0);
> musb_writeb(musb->mregs, MUSB_FADDR, 0);
> }
>
> This is from the interrupt handler in the sunxi-musb glue in the kernel,
> maybe we can do the same, and/or maybe we need to do:
>
> /* ep0 FADDR must be 0 when (re)entering peripheral mode */
> musb_ep_select(musb->mregs, 0);
> musb_writeb(musb->mregs, MUSB_FADDR, 0);
>
> From sunxi_musb_disable?
So, I was affected by this issue on a SinA33, even when not switching
roles (since the SinA33 is peripheral only). The issue I was seeing
what that when I was two subsequent use of any gadget (fastboot, USB
ethernet traffic), the second would silently fail on U-boot side with
the host failing to enumerate the device.
Paul pointed me to that thread, and your suggestion on EP0 seems like
a good lead, since the ugly http://pastebin.com/9Y6S9Hpw makes it work.
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150626/ab5df87f/attachment.sig>
next prev parent reply other threads:[~2015-06-26 10:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-14 10:40 [U-Boot] [PATCH 0/2] sunxi: musb: Fix "usb reset" handling Hans de Goede
2015-06-14 10:40 ` [U-Boot] [PATCH 1/2] sunxi: musb: Do not fully reset the controler from sunxi_musb_disable Hans de Goede
2015-06-14 11:46 ` Ian Campbell
2015-06-14 17:21 ` Hans de Goede
2015-06-14 10:40 ` [U-Boot] [PATCH 2/2] sunxi: musb: Remove unused sunxi_musb_exit method Hans de Goede
2015-06-14 11:47 ` Ian Campbell
2015-06-15 19:21 ` [U-Boot] [PATCH 0/2] sunxi: musb: Fix "usb reset" handling Paul Kocialkowski
2015-06-17 13:39 ` Hans de Goede
2015-06-19 9:11 ` Paul Kocialkowski
2015-06-19 12:35 ` Marek Vasut
2015-06-19 13:07 ` Hans de Goede
2015-06-19 13:08 ` Marek Vasut
2015-06-26 10:20 ` Maxime Ripard [this message]
2015-06-26 11:01 ` Hans de Goede
2015-06-28 20:42 ` Maxime Ripard
2015-06-26 11:02 ` Hans de Goede
2015-06-26 11:11 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150626102058.GM2266@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox