From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] powerpc/mpc85xx:Add GCC flag -fno-delete-null-pointer-checks
Date: Tue, 30 Jun 2015 14:22:30 -0400 [thread overview]
Message-ID: <20150630182230.GD28577@bill-the-cat> (raw)
In-Reply-To: <CAPnjgZ1eWCtvxYvrz9=3Nbv7dddMs1J0SOPFXs+H4uVScYp4Ow@mail.gmail.com>
On Tue, Jun 30, 2015 at 08:58:26AM -0600, Simon Glass wrote:
> Hi,
>
> On 29 June 2015 at 22:18, Kushwaha Prabhakar <prabhakar@freescale.com> wrote:
> > Hi Simon, Tom,
> >
> > -fdelete-null-pointer-checks flag controls global dataflow analyses and eliminate useless checks for null pointers; It assume that if a pointer is checked after it has already been dereferenced, it cannot be null. This flag is enabled by default.
> > gcc v4.9 has more optimizations added to this option. Hence it is very aggressive with GCC v4.9 series. It is also well documented in the GCC v4.9 release notes:
> > https://gcc.gnu.org/gcc-4.9/porting_to.html
> >
> > There is possibility after moving to gcc-4.9 some platform may/may not work properly.
> > I tested this patch for freescale powerpc platforms.
> > But It may needs be taken care by all architecture like ARM, powerpc. If this is the case; this flag should be in top level Makefile (not sure)
> >
>
> I suspect a top-level option would be best, perhaps near this one in Makefile:
>
> KBUILD_CFLAGS += $(call cc-option,-fno-stack-protector)
I also agree with Scott and Simon, default, top level, using cc-option
just like the Linux kernel please, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150630/02bb2b87/attachment.sig>
next prev parent reply other threads:[~2015-06-30 18:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 6:07 [U-Boot] [PATCH] powerpc/mpc85xx:Add GCC flag -fno-delete-null-pointer-checks Prabhakar Kushwaha
2015-05-20 17:10 ` York Sun
2015-05-20 17:33 ` Scott Wood
2015-06-30 4:18 ` Kushwaha Prabhakar
2015-06-30 14:58 ` Simon Glass
2015-06-30 18:22 ` Tom Rini [this message]
2015-07-01 3:10 ` Kushwaha Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150630182230.GD28577@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox