From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Thu, 2 Jul 2015 13:13:58 +0200
Subject: [U-Boot] [PATCH v1 8/9] usb: Add EHCI support for Armada 38x
	(mvebu)
In-Reply-To: <55951A85.3070506@denx.de>
References: <1435582696-30068-1-git-send-email-sr@denx.de>
 <201506291722.44585.marex@denx.de> <55951A85.3070506@denx.de>
Message-ID: <201507021313.58211.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Thursday, July 02, 2015 at 01:03:33 PM, Stefan Roese wrote:
> Hi Marek,
> 
> On 29.06.2015 17:22, Marek Vasut wrote:
> > On Monday, June 29, 2015 at 02:58:15 PM, Stefan Roese wrote:
> >> This patch adds USB EHCI host support for the common mvebu platform.
> >> Including the Armada 38x.
> >> 
> >> Tested on DB-88F6280-GP eval board.
> >> 
> >> Signed-off-by: Stefan Roese <sr@denx.de>
> >> Cc: Marek Vasut <marex@denx.de>
> >> Cc: Luka Perkov <luka.perkov@sartura.hr>
> > 
> > Reviewed-by: Marek Vasut <marex@denx.de>
> 
> Thanks.
> 
> > [...]
> > 
> >> +static void usb_brg_adrdec_setup(void)
> >> +{
> >> +	const struct mbus_dram_target_info *dram;
> >> +	int i;
> >> +
> >> +	dram = mvebu_mbus_dram_info();
> >> +
> >> +	for (i = 0; i < 4; i++) {
> >> +		wrl(USB_WINDOW_CTRL(i), 0);
> >> +		wrl(USB_WINDOW_BASE(i), 0);
> >> +	}
> > 
> > These wrl() accessors are a bit weird, but maybe there's some
> > marvell magic behind this?
> 
> Not really. They are just adding the controller base address. Its used
> in the current driver code - so I just used it here as well.
> 
> I'll send a patch to remove these macros (move to readl/writel) once all
> this is in mainline.

I guess that makes sense eventually, yeah. Thanks :)

Best regards,
Marek Vasut