From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, u-boot, 2/2] ARM: beagle_x15: prevent DCAN1 _wait_target_disable failure in kernel
Date: Fri, 10 Jul 2015 08:57:32 -0400 [thread overview]
Message-ID: <20150710125732.GC23886@bill-the-cat> (raw)
In-Reply-To: <1435217150-16827-1-git-send-email-rogerq@ti.com>
On Thu, Jun 25, 2015 at 10:25:50AM +0300, Roger Quadros wrote:
> If board is booted with transitions happening on DCAN1 pins then
> the following warning is seen in the kernel at boot when the
> hwmod layer initializes.
>
> "omap_hwmod: dcan1: _wait_target_disable failed"
>
> This is because DCAN1 module's SWAKEUP mechanism is broken
> and it fails to correctly turn OFF if it sees a transition on the
> DCAN1 pins. Suggested workaround is to keep DCAN1 pins in safe mode
> while enabling/disabling DCAN1 module.
>
> The hwmod layer enables and disables all modules at boot
> and we have no opportunity to put the DCAN1 pins in safe mode
> at that point.
>
> DCAN1 is not used by u-boot so it doesn't matter to it if these
> pins are in safe mode. The kernel driver correctly configures
> the right mode when DCAN1 is active.
>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
With %s/PULLUP/PULL_UP/ based on the DRA7xx patch, applied to
u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150710/40655270/attachment.sig>
next prev parent reply other threads:[~2015-07-10 12:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-24 14:00 [U-Boot] [u-boot][PATCH] ARM: DRA7-evm: prevent DCAN1 _wait_target_disable failure in kernel Roger Quadros
2015-06-24 17:40 ` Nishanth Menon
2015-06-25 7:25 ` [U-Boot] [u-boot][PATCH 2/2] ARM: beagle_x15: " Roger Quadros
2015-07-10 12:57 ` Tom Rini [this message]
2015-07-13 10:41 ` [U-Boot] [U-Boot, u-boot, " Roger Quadros
2015-07-10 12:56 ` [U-Boot] [U-Boot, u-boot] ARM: DRA7-evm: " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150710125732.GC23886@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox