From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peng Fan Date: Sun, 12 Jul 2015 18:32:28 +0800 Subject: [U-Boot] [PATCH V2 03/15] imx: mx6ul: Update imx registers head file In-Reply-To: <201507120011.42843.marex@denx.de> References: <1436602043-9644-1-git-send-email-Peng.Fan@freescale.com> <1436602043-9644-4-git-send-email-Peng.Fan@freescale.com> <201507120011.42843.marex@denx.de> Message-ID: <20150712103227.GB16931@shlinux2> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Marek, On Sun, Jul 12, 2015 at 12:11:42AM +0200, Marek Vasut wrote: >On Saturday, July 11, 2015 at 10:07:11 AM, Peng Fan wrote: >> 1. Update imx register base address for i.MX6UL. >> 2. Remove duplicated MXS_APBH/GPMI/BCH_BASE. >> 3. Remove #ifdef for register addresses that equal to >> "AIPS2_OFF_BASE_ADDR + 0x34000" for different chips. >> 4. According fuse map, complete fuse_bank4_regs. >> 5. Move AIPS3_ARB_BASE_ADDR and AIPS3_ARB_END_ADDR out of #ifdef >> CONFIG_MX6SX, because we can use runtime check >> >> Signed-off-by: Peng Fan >> --- > >[...] > >> @@ -309,11 +311,16 @@ >> #define PWM8_BASE_ADDR (AIPS3_ARB_BASE_ADDR + 0xB0000) >> #endif >> >> +/* only for i.MX6SX/UL */ >> +#define WDOG3_BASE_ADDR (is_cpu_type(MXC_CPU_MX6UL) ? \ >> + (AIPS2_OFF_BASE_ADDR + 0x64000) : \ >> + (AIPS3_ARB_BASE_ADDR + 0x88000)) >> + > >This might not work if used in assembler. I did not see any scenario that it will be used in assembler now. If we truely need it in assembler, then we can not avoid so many "ifdef"s. > >Best regards, >Marek Vasut Regards, Peng. --