From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Mon, 13 Jul 2015 17:53:24 +0200
Subject: [U-Boot] [PATCH 14/16] cgtqmx6eval: Add splash screen support
In-Reply-To: <1436800998-21248-14-git-send-email-otavio@ossystems.com.br>
References: <1436800998-21248-1-git-send-email-otavio@ossystems.com.br>
 <1436800998-21248-14-git-send-email-otavio@ossystems.com.br>
Message-ID: <201507131753.24221.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Monday, July 13, 2015 at 05:23:16 PM, Otavio Salvador wrote:
> Add LVDS and HDMI support.
> 
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>

[...]

> +static void setup_display(void)
> +{
> +	struct mxc_ccm_reg *mxc_ccm = (struct mxc_ccm_reg *)CCM_BASE_ADDR;
> +	struct iomuxc *iomux = (struct iomuxc *)IOMUXC_BASE_ADDR;
> +	int reg;
> +
> +	enable_ipu_clock();
> +	imx_setup_hdmi();
> +
> +	/* Turn on LDB0, LDB1, IPU,IPU DI0 clocks */
> +	reg = __raw_readl(&mxc_ccm->CCGR3);
> +	reg |= MXC_CCM_CCGR3_LDB_DI0_MASK | MXC_CCM_CCGR3_LDB_DI1_MASK;

setbits_le32() ?

> +	writel(reg, &mxc_ccm->CCGR3);

[...]

> +	reg = readl(&iomux->gpr[3]);
> +	reg = (reg & ~(IOMUXC_GPR3_LVDS1_MUX_CTL_MASK |
> +	       IOMUXC_GPR3_HDMI_MUX_CTL_MASK))
> +	    | (IOMUXC_GPR3_MUX_SRC_IPU1_DI0 <<
> +	       IOMUXC_GPR3_LVDS1_MUX_CTL_OFFSET);

Why is this pipe (bitwise OR operator) once on the right, the next time
on the left ? Consistency please :-(

> +	writel(reg, &iomux->gpr[3]);
> +}
[...]

Best regards,
Marek Vasut