From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC] lib/fdtdec: Fix compiling warning for debug
Date: Thu, 16 Jul 2015 09:01:43 +0200 [thread overview]
Message-ID: <20150716090143.3e93c921@lilith> (raw)
In-Reply-To: <1436992006-32644-1-git-send-email-yorksun@freescale.com>
Hello York,
On Wed, 15 Jul 2015 13:26:46 -0700, York Sun <yorksun@freescale.com>
wrote:
> fdt_addr_t and fdt_size_t can be either 64-bit or 32-bit, depending
> on the architecture. Change the type to phys_addr_t and phys_size_t.
If the only reason for changing the type is to avoid warnings in
debug() then I don't think this is the right approach (see my message
re PRIu64).
If, on the other hand, there is reason to believe the fdt_addr_t and
fdt_size_t are wrongly defined and should be typedef'd or ~define's as
phys_*_t, then the rationale for this should be exposed.
Amicalement,
--
Albert.
next prev parent reply other threads:[~2015-07-16 7:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-15 20:26 [U-Boot] [RFC] lib/fdtdec: Fix compiling warning for debug York Sun
2015-07-16 7:01 ` Albert ARIBAUD [this message]
2015-07-16 16:40 ` Simon Glass
2015-07-16 17:00 ` York Sun
2015-07-16 17:10 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150716090143.3e93c921@lilith \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox