From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/4] nand: lpc32xx: add SLC NAND controller support
Date: Thu, 16 Jul 2015 14:53:58 +0200 [thread overview]
Message-ID: <20150716145358.16abeb70@lilith> (raw)
In-Reply-To: <1437003228-14746-3-git-send-email-vz@mleia.com>
Hello Vladimir,
On Thu, 16 Jul 2015 02:33:46 +0300, Vladimir Zapolskiy <vz@mleia.com>
wrote:
> diff --git a/drivers/mtd/nand/lpc32xx_nand_slc.c b/drivers/mtd/nand/lpc32xx_nand_slc.c
> new file mode 100644
> +int board_nand_init(struct nand_chip *lpc32xx_chip)
> +{
> + lpc32xx_chip->IO_ADDR_R = &lpc32xx_nand_slc_registers->data;
> + lpc32xx_chip->IO_ADDR_W = &lpc32xx_nand_slc_registers->data;
Consistent with my comment re nand_simpl.c, I think that the two
assignments above are incorrect since the data register may not provide
general access to the NAND's I/O lines, and is not 8-bit accessible
even though the NAND is 8-bit wide.
If Scott give his go, though, disregard my comment.
Amicalement,
--
Albert.
next prev parent reply other threads:[~2015-07-16 12:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-15 23:33 [U-Boot] [PATCH 0/4] lpc32xx: devkit3250 board update Vladimir Zapolskiy
2015-07-15 23:33 ` [U-Boot] [PATCH 1/4] spl: nand: simple: replace readb() with chip specific read_buf() Vladimir Zapolskiy
2015-07-16 8:02 ` Albert ARIBAUD
2015-07-16 11:31 ` Vladimir Zapolskiy
2015-07-16 12:43 ` Albert ARIBAUD
2015-07-16 13:48 ` Vladimir Zapolskiy
2015-07-16 14:12 ` Albert ARIBAUD
2015-07-16 19:30 ` Scott Wood
2015-07-15 23:33 ` [U-Boot] [PATCH 2/4] nand: lpc32xx: add SLC NAND controller support Vladimir Zapolskiy
2015-07-16 12:53 ` Albert ARIBAUD [this message]
2015-07-16 20:14 ` Scott Wood
2015-07-16 20:18 ` Vladimir Zapolskiy
2015-07-16 20:20 ` Scott Wood
2015-07-16 20:29 ` Vladimir Zapolskiy
2015-07-15 23:33 ` [U-Boot] [PATCH 3/4] lpc32xx: devkit3250: update of board configuration Vladimir Zapolskiy
2015-07-16 7:27 ` Albert ARIBAUD
2015-07-16 12:05 ` Vladimir Zapolskiy
2015-07-16 12:45 ` Albert ARIBAUD
2015-07-15 23:33 ` [U-Boot] [PATCH 4/4] lpc32xx: devkit3250: add spl build support Vladimir Zapolskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150716145358.16abeb70@lilith \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox