[U-Boot] [PATCH 1/4] sunxi: nand: Add basic sunxi NAND driver with DMA support

Piotr Zierhoffer
2015-07-17T14:39:52Z

2015-07-16 23:15 GMT+02:00 Scott Wood <scottwood@freescale.com>:
> On Thu, 2015-07-16 at 13:25 +0200, Piotr Zierhoffer wrote:
>> From: Piotr Zierhoffer <piotr.zierhoffer@cs.put.poznan.pl>
>>
>> This driver adds NAND support to both SPL and full U-Boot.
>> It was tested on AllWinner A20.
>
> It looks a lot like an SPL-only driver to me...
>

I am preparing a v2 patch set, that will have SPL-only code.

>> + writel(0x00E00530, NANDFLASHC_BASE + NANDFLASHC_RCMD_SET); /* READ */
>
> What is 0x00e00530? Define it symbolically.
>

It's difficult because we do not have much explanation for this
constant. This is how BROM operates.
We have tuned it according to http://linux-sunxi.org/NFC_Register_Guide

We have fixed the code according to your comments and will resubmit it shortly.

Best regards

Piotr Zierhoffer
Antmicro Ltd | www.antmicro.com