From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Tue, 21 Jul 2015 04:03:29 +0200
Subject: [U-Boot] [PATCH 0/3] add dfu support for at91 sam9260 based
	boards
In-Reply-To: <20150720160308.68a9af31@amdc2363>
References: <1434372182-8967-1-git-send-email-hs@denx.de>
 <20150720160308.68a9af31@amdc2363>
Message-ID: <201507210403.29493.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Monday, July 20, 2015 at 04:03:08 PM, Lukasz Majewski wrote:
> Hi Marek,
> 
> > add dfu supprt for at91 sam9260 based boards. The USB
> > gadget driver is ported from linux:
> > 
> > b2ba27a5c56ff: usb: gadget: at91_udc: move prepare clk into process
> > context
> > 
> > it drops a lot of checkpatch warnings/errors:
> > 
> > checkpatch.pl found 12 error(s), 31 warning(s), 43 checks(s)
> > 
> > but for further updates I did not fix them.
> > The errors are all from this sort:
> > 
> > error: drivers/usb/gadget/at91_udc.c,87: space prohibited before open
> > square bracket '['
> > 
> > a lot of "line over 80 characters" warnings ...
> > 
> > Heiko Schocher (3):
> >   ARM: at91: add cpu.h
> >   usb: gadget: at91_udc: add support for at91_udc
> >   at91, taurus, smartweb: add dfu support
> 
> Marek, do you plan to review this patch series?
> 
> (I would need at least one review before I pull the code).

I took a brief look. One thing I don't quite like is the omnipresent #ifdef 
__UBOOT__ stuff. I'd much rather love to see some kind of a porting layer
so the driver can just be picked from linux as-is, but that might be too much
hassle.

Otherwise, I'm fine with it, though I nitpicked a bit.

Best regards,
Marek Vasut