public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Lukasz Majewski <l.majewski@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ci_udc: fix 64-bit compile warnings
Date: Thu, 23 Jul 2015 09:00:53 +0200	[thread overview]
Message-ID: <20150723090053.45644478@amdc2363> (raw)
In-Reply-To: <1437599780-12787-1-git-send-email-swarren@wwwdotorg.org>

Hi Marek,

> From: Stephen Warren <swarren@nvidia.com>
> 
> This is the same as f72d8320b605 "usb: ci_udc: fix warnings on 64-bit
> builds", but more.
> 
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
>  drivers/usb/gadget/ci_udc.c | 19 ++++++++++---------
>  1 file changed, 10 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/usb/gadget/ci_udc.c b/drivers/usb/gadget/ci_udc.c
> index aadff42a9cdc..993be315a8cf 100644
> --- a/drivers/usb/gadget/ci_udc.c
> +++ b/drivers/usb/gadget/ci_udc.c
> @@ -221,8 +221,8 @@ static void ci_flush_qtd(int ep_num)
>   */
>  static void ci_flush_td(struct ept_queue_item *td)
>  {
> -	const uint32_t  start = (uint32_t)td;
> -	const uint32_t end = (uint32_t) td + ILIST_ENT_SZ;
> +	const unsigned long start = (unsigned long)td;
> +	const unsigned long end = (unsigned long)td + ILIST_ENT_SZ;
>  	flush_dcache_range(start, end);
>  }
>  
> @@ -249,8 +249,8 @@ static void ci_invalidate_qtd(int ep_num)
>   */
>  static void ci_invalidate_td(struct ept_queue_item *td)
>  {
> -	const uint32_t start = (uint32_t)td;
> -	const uint32_t end = start + ILIST_ENT_SZ;
> +	const unsigned long start = (unsigned long)td;
> +	const unsigned long end = start + ILIST_ENT_SZ;
>  	invalidate_dcache_range(start, end);
>  }
>  
> @@ -459,7 +459,7 @@ static void ci_ep_submit_next_request(struct
> ci_ep *ci_ep) if (len) {
>  			qtd = (struct ept_queue_item *)
>  			       memalign(ILIST_ALIGN, ILIST_ENT_SZ);
> -			dtd->next = (uint32_t)qtd;
> +			dtd->next = (unsigned long)qtd;
>  			dtd = qtd;
>  			memset(dtd, 0, ILIST_ENT_SZ);
>  		}
> @@ -503,10 +503,10 @@ static void ci_ep_submit_next_request(struct
> ci_ep *ci_ep) 
>  	ci_flush_qtd(num);
>  
> -	item = (struct ept_queue_item *)head->next;
> +	item = (struct ept_queue_item *)(unsigned long)head->next;
>  	while (item->next != TERMINATE) {
> -		ci_flush_td((struct ept_queue_item *)item->next);
> -		item = (struct ept_queue_item *)item->next;
> +		ci_flush_td((struct ept_queue_item *)(unsigned
> long)item->next);
> +		item = (struct ept_queue_item *)(unsigned
> long)item->next; }
>  
>  	DBG("ept%d %s queue len %x, req %p, buffer %p\n",
> @@ -594,7 +594,8 @@ static void handle_ep_complete(struct ci_ep
> *ci_ep) printf("EP%d/%s FAIL info=%x pg0=%x\n",
>  			       num, in ? "in" : "out", item->info,
> item->page0); if (j != ci_req->dtd_count - 1)
> -			next_td = (struct ept_queue_item
> *)item->next;
> +			next_td = (struct ept_queue_item *)(unsigned
> long)
> +				item->next;
>  		if (j != 0)
>  			free(item);
>  	}

Should I take the patch to -dfu tree?

-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

  parent reply	other threads:[~2015-07-23  7:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-22 21:16 [U-Boot] [PATCH] ci_udc: fix 64-bit compile warnings Stephen Warren
2015-07-23  7:00 ` Marek Vasut
2015-07-23  7:00 ` Lukasz Majewski [this message]
2015-07-23  7:03   ` Marek Vasut
2015-07-23  7:09 ` Lukasz Majewski
2015-07-23  7:19   ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150723090053.45644478@amdc2363 \
    --to=l.majewski@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox