From: Lukasz Majewski <l.majewski@majess.pl>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/9] net: tftp: Move tftp.h file from ./net to ./include/net
Date: Sat, 25 Jul 2015 17:02:18 +0200 [thread overview]
Message-ID: <20150725170218.5b5ff300@jawa> (raw)
In-Reply-To: <20150725122443.D3FDB380587@gemini.denx.de>
On Sat, 25 Jul 2015 14:24:43 +0200
Wolfgang Denk <wd@denx.de> wrote:
> Dear Lukasz Majewski,
>
> In message <1437811877-13764-3-git-send-email-l.majewski@majess.pl>
> you wrote:
> > This change gives the ability to reuse the <tftp.h> header file by
> > other subsystems (like e.g. dfu).
> >
> > Without this change compilation error emerges for the legacy
> > update.c file.
> >
> > Signed-off-by: Lukasz Majewski <l.majewski@majess.pl>
> >
> > ---
> > Changes for v2:
> > - Move tftp.h from ./include to ./include/net/ directory
> > ---
> > include/net/tftp.h | 30 ++++++++++++++++++++++++++++++
> > net/bootp.c | 2 +-
> > net/net.c | 2 +-
> > net/rarp.c | 2 +-
> > net/tftp.c | 2 +-
> > net/tftp.h | 30 ------------------------------
> > 6 files changed, 34 insertions(+), 34 deletions(-)
> > create mode 100644 include/net/tftp.h
> > delete mode 100644 net/tftp.h
>
> NAK. Please resubmit and use "-M -C" when generating the patches, so
> the renames will be properly detected and not result in a file
> deletion and the addition of an (apparently new) file.
Ok, Thanks for pointing this out.
>
> Best regards,
>
> Wolfgang Denk
>
Best regards,
Lukasz Majewski
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150725/7b9ccc18/attachment.sig>
next prev parent reply other threads:[~2015-07-25 15:02 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-25 8:11 [U-Boot] [PATCH v2 0/9] dfu: tftp: update: Support for DFU upgrades via ETH (TFTP) Lukasz Majewski
2015-07-25 8:11 ` [U-Boot] [PATCH v2 1/9] doc: dfu: tftp: README entry for TFTP extension of DFU Lukasz Majewski
2015-08-02 22:30 ` Simon Glass
2015-08-03 11:22 ` Lukasz Majewski
2015-07-25 8:11 ` [U-Boot] [PATCH v2 2/9] net: tftp: Move tftp.h file from ./net to ./include/net Lukasz Majewski
2015-07-25 12:24 ` Wolfgang Denk
2015-07-25 15:02 ` Lukasz Majewski [this message]
2015-07-25 15:06 ` Simon Glass
2015-07-25 8:11 ` [U-Boot] [PATCH v2 3/9] tftp: update: Allow some parts of the code to be reused when CONFIG_SYS_NO_FLASH is set Lukasz Majewski
2015-08-02 22:30 ` Simon Glass
2015-07-25 8:11 ` [U-Boot] [PATCH v2 4/9] dfu: tftp: update: Provide tftp support for the DFU subsystem Lukasz Majewski
2015-08-02 22:30 ` Simon Glass
2015-08-09 21:10 ` Lukasz Majewski
2015-08-07 21:31 ` Joe Hershberger
2015-07-25 8:11 ` [U-Boot] [PATCH v2 5/9] dfu: tftp: update: Add dfu_write_from_mem_addr() function Lukasz Majewski
2015-08-02 22:30 ` Simon Glass
2015-08-09 21:37 ` Lukasz Majewski
2015-08-07 21:32 ` Joe Hershberger
2015-07-25 8:11 ` [U-Boot] [PATCH v2 6/9] update: tftp: dfu: Extend update_tftp() function to support DFU Lukasz Majewski
2015-08-02 22:30 ` Simon Glass
2015-08-10 17:01 ` Lukasz Majewski
2015-08-10 18:52 ` Simon Glass
2015-08-07 21:32 ` Joe Hershberger
2015-07-25 8:11 ` [U-Boot] [PATCH v2 7/9] dfu: command: Extend "dfu" command to handle receiving data via TFTP Lukasz Majewski
2015-08-02 22:30 ` Simon Glass
2015-08-07 21:32 ` Joe Hershberger
2015-07-25 8:11 ` [U-Boot] [PATCH v2 8/9] config: bbb: Configs necessary for running update via TFTP on Beagle Bone Black Lukasz Majewski
2015-08-02 22:30 ` Simon Glass
2015-08-07 21:32 ` Joe Hershberger
2015-07-25 8:11 ` [U-Boot] [PATCH v2 9/9] dfu:tests: Modify dfu_gadget_test.sh to accept USB device major:minor number Lukasz Majewski
2015-08-02 22:30 ` Simon Glass
2015-08-07 21:32 ` Joe Hershberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150725170218.5b5ff300@jawa \
--to=l.majewski@majess.pl \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox