public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] dm: core: Allow simple-bus driver in SPL
@ 2015-07-27 20:31 Marek Vasut
  2015-08-02 21:28 ` Simon Glass
  0 siblings, 1 reply; 3+ messages in thread
From: Marek Vasut @ 2015-07-27 20:31 UTC (permalink / raw)
  To: u-boot

There's no reason why simple-bus driver can not be used in SPL,
in fact it is necessary to get SoCFPGA SPL probe the cadence
SPI driver. So drop the restriction.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Simon Glass <sjg@chromium.org>
---
 drivers/core/Makefile | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/core/Makefile b/drivers/core/Makefile
index 5c2ead8..87b7c98 100644
--- a/drivers/core/Makefile
+++ b/drivers/core/Makefile
@@ -5,9 +5,7 @@
 #
 
 obj-y	+= device.o lists.o root.o uclass.o util.o
-ifndef CONFIG_SPL_BUILD
 obj-$(CONFIG_OF_CONTROL) += simple-bus.o
-endif
 obj-$(CONFIG_DM_DEVICE_REMOVE)	+= device-remove.o
 obj-$(CONFIG_DM)	+= dump.o
 obj-$(CONFIG_OF_CONTROL)	+= regmap.o
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] dm: core: Allow simple-bus driver in SPL
  2015-07-27 20:31 [U-Boot] [PATCH] dm: core: Allow simple-bus driver in SPL Marek Vasut
@ 2015-08-02 21:28 ` Simon Glass
  2015-08-02 23:16   ` Marek Vasut
  0 siblings, 1 reply; 3+ messages in thread
From: Simon Glass @ 2015-08-02 21:28 UTC (permalink / raw)
  To: u-boot

Hi Marek,

On 27 July 2015 at 14:31, Marek Vasut <marex@denx.de> wrote:
> There's no reason why simple-bus driver can not be used in SPL,
> in fact it is necessary to get SoCFPGA SPL probe the cadence
> SPI driver. So drop the restriction.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Simon Glass <sjg@chromium.org>
> ---
>  drivers/core/Makefile | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/core/Makefile b/drivers/core/Makefile
> index 5c2ead8..87b7c98 100644
> --- a/drivers/core/Makefile
> +++ b/drivers/core/Makefile
> @@ -5,9 +5,7 @@
>  #
>
>  obj-y  += device.o lists.o root.o uclass.o util.o
> -ifndef CONFIG_SPL_BUILD
>  obj-$(CONFIG_OF_CONTROL) += simple-bus.o
> -endif
>  obj-$(CONFIG_DM_DEVICE_REMOVE) += device-remove.o
>  obj-$(CONFIG_DM)       += dump.o
>  obj-$(CONFIG_OF_CONTROL)       += regmap.o
> --
> 2.1.4
>

Can you please instead add a new Kconfigs CONFIG_SIMPLE_BUS and
CONFIG_SPL_SIMPLE_BUS? They can be default on. If we force all SPLs to
have this, it does add bloat.

Regards,
Simon

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] dm: core: Allow simple-bus driver in SPL
  2015-08-02 21:28 ` Simon Glass
@ 2015-08-02 23:16   ` Marek Vasut
  0 siblings, 0 replies; 3+ messages in thread
From: Marek Vasut @ 2015-08-02 23:16 UTC (permalink / raw)
  To: u-boot

On Sunday, August 02, 2015 at 11:28:10 PM, Simon Glass wrote:
> Hi Marek,
> 
> On 27 July 2015 at 14:31, Marek Vasut <marex@denx.de> wrote:
> > There's no reason why simple-bus driver can not be used in SPL,
> > in fact it is necessary to get SoCFPGA SPL probe the cadence
> > SPI driver. So drop the restriction.
> > 
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Simon Glass <sjg@chromium.org>
> > ---
> > 
> >  drivers/core/Makefile | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/drivers/core/Makefile b/drivers/core/Makefile
> > index 5c2ead8..87b7c98 100644
> > --- a/drivers/core/Makefile
> > +++ b/drivers/core/Makefile
> > @@ -5,9 +5,7 @@
> > 
> >  #
> >  
> >  obj-y  += device.o lists.o root.o uclass.o util.o
> > 
> > -ifndef CONFIG_SPL_BUILD
> > 
> >  obj-$(CONFIG_OF_CONTROL) += simple-bus.o
> > 
> > -endif
> > 
> >  obj-$(CONFIG_DM_DEVICE_REMOVE) += device-remove.o
> >  obj-$(CONFIG_DM)       += dump.o
> >  obj-$(CONFIG_OF_CONTROL)       += regmap.o
> > 
> > --
> > 2.1.4
> 
> Can you please instead add a new Kconfigs CONFIG_SIMPLE_BUS and
> CONFIG_SPL_SIMPLE_BUS? They can be default on. If we force all SPLs to
> have this, it does add bloat.

Done

Best regards,
Marek Vasut

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-08-02 23:16 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-27 20:31 [U-Boot] [PATCH] dm: core: Allow simple-bus driver in SPL Marek Vasut
2015-08-02 21:28 ` Simon Glass
2015-08-02 23:16   ` Marek Vasut

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox