From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] configs: ti_armv7_keystone2: fix initrd address at args_ramfs
Date: Tue, 4 Aug 2015 12:16:22 -0400 [thread overview]
Message-ID: <20150804161622.GA25532@bill-the-cat> (raw)
In-Reply-To: <55C0DE0D.3040609@ti.com>
On Tue, Aug 04, 2015 at 11:45:17AM -0400, Vitaly Andrianov wrote:
>
>
> On 08/04/2015 11:23 AM, Tom Rini wrote:
> >On Tue, Aug 04, 2015 at 11:16:15AM -0400, Vitaly Andrianov wrote:
> >
> >>This patch set the correct initrd address to much rdaddr, which used at
> >>get_fs_ramfs commad.
> >>
> >>Fixes: 3e97f0b63c8e ("configs: ti_armv7_keystone2: switch addresses
> >>to generic addresses")
> >>
> >>Signed-off-by: Vitaly Andrianov <vitalya@ti.com>
> >>---
> >> include/configs/ti_armv7_keystone2.h | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >>diff --git a/include/configs/ti_armv7_keystone2.h b/include/configs/ti_armv7_keystone2.h
> >>index 7b67620..454f1df 100644
> >>--- a/include/configs/ti_armv7_keystone2.h
> >>+++ b/include/configs/ti_armv7_keystone2.h
> >>@@ -253,7 +253,7 @@
> >> "init_ramfs=run args_all args_ramfs get_fs_ramfs\0" \
> >> "args_ramfs=setenv bootargs ${bootargs} " \
> >> "rdinit=/sbin/init rw root=/dev/ram0 " \
> >>- "initrd=0x802000000,9M\0" \
> >>+ "initrd=0x808080000,9M\0" \
> >
> >There's two related problems here. Making initrd match ${rdaddr} would
> >be best done by doing "initrd=${rdaddr}" here, same as whacking in the
>
> For keystone devices we load filesystem at ${rdaddr}, but need to pass
> to the kernel initrd=<${rdaddr} + 0x780000000)>, which is LPAE address.
Why do you need to do that? Shouldn't the kernel be able to move things
around as needed? But if we must then please do some expr to do that
addition so that if people change rdaddr they don't get unexpected
breakage.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150804/05057b58/attachment.sig>
next prev parent reply other threads:[~2015-08-04 16:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 15:16 [U-Boot] [PATCH 0/2] configs: ti_armv7_keystone2: fix default args_ramfs Vitaly Andrianov
2015-08-04 15:16 ` [U-Boot] [PATCH 1/2] configs: ti_armv7_keystone2: fix initrd address at args_ramfs Vitaly Andrianov
2015-08-04 15:23 ` Tom Rini
2015-08-04 15:45 ` Vitaly Andrianov
2015-08-04 16:16 ` Tom Rini [this message]
2015-08-13 13:23 ` [U-Boot] [U-Boot, " Tom Rini
2015-08-04 15:16 ` [U-Boot] [PATCH 2/2] configs: ti_armv7_keystone2: increase size reserved for initrd Vitaly Andrianov
2015-08-13 13:23 ` [U-Boot] [U-Boot, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150804161622.GA25532@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox