From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] dm: usb: fix USB Ethernet without CONFIG_DM_ETH regression
Date: Wed, 5 Aug 2015 17:19:31 +0200 [thread overview]
Message-ID: <201508051719.31182.marex@denx.de> (raw)
In-Reply-To: <cbc4058a57d6a7d0b16e2cd3e7b48af724b05b59.1438785774.git.marcel.ziswiler@toradex.com>
On Wednesday, August 05, 2015 at 04:58:17 PM, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> The following commit enforces CONFIG_DM_ETH for USB Ethernet which
> breaks any board using CONFIG_USB_HOST_ETHER without CONFIG_DM_ETH
> which this patch fixes.
>
> commit 69559093f6173dcfcb041df0995063bdbd07d49b
> dm: usb: Avoid using USB ethernet with CONFIG_DM_USB and no DM_ETH
>
> Tested on Colibri T20/T30 as well as Apalis T30 with
> CONFIG_USB_HOST_ETHER and CONFIG_USB_ETHER_ASIX enabled and a LevelOne
> USB-0301 ASIX AX88772 dongle.
>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> ---
> Changes in v2: Fix commit message as pointed out by Simon.
>
> common/cmd_usb.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
Dumb question -- won't it make more sense to add USB_HOST_ETHER Kconfig
option and make it depend on CONFIG_DM_USB ?
Best regards,
Marek Vasut
next prev parent reply other threads:[~2015-08-05 15:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-05 14:58 [U-Boot] [PATCH v2] dm: usb: fix USB Ethernet without CONFIG_DM_ETH regression Marcel Ziswiler
2015-08-05 15:19 ` Marek Vasut [this message]
2015-08-05 15:25 ` Marcel Ziswiler
2015-08-05 15:55 ` Marek Vasut
2015-08-05 15:29 ` Simon Glass
2015-08-05 15:45 ` Marcel Ziswiler
2015-08-09 15:06 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201508051719.31182.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox