public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3][v2] imx: usb: ehci-mx6: document board specific functions
Date: Wed, 5 Aug 2015 23:31:21 +0200	[thread overview]
Message-ID: <201508052331.21740.marex@denx.de> (raw)
In-Reply-To: <1438808616-25585-2-git-send-email-aalonso@freescale.com>

On Wednesday, August 05, 2015 at 11:03:35 PM, Adrian Alonso wrote:
> Document target board specific functions
> 
> board_ehci_hcd_init - override usb phy mode
> board_ehci_hcd_init - set usb vbus voltage
> board_ehci_power - enables/disables usb vbus voltage
> 
> Signed-off-by: Adrian Alonso <aalonso@freescale.com>
> ---
> Changes for V2:
> Split from patch imx: usb: ehci-mx6: add usb support for imx7d soc
> 
>  drivers/usb/host/ehci-mx6.c | 31 +++++++++++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
> 
> diff --git a/drivers/usb/host/ehci-mx6.c b/drivers/usb/host/ehci-mx6.c
> index 0f94c8b..afc248b 100644
> --- a/drivers/usb/host/ehci-mx6.c
> +++ b/drivers/usb/host/ehci-mx6.c
> @@ -195,16 +195,47 @@ int usb_phy_mode(int port)
>  		return USB_INIT_HOST;
>  }
> 
> +/*

The kerneldoc starts with /** , the tool to generate the documentation
actually depends on that. Can you please fix this one thing and slap my

Acked-by: Marek Vasut <marex@denx.de>

on this patch when re-posting ?

[...]

Best regards,
Marek Vasut

  reply	other threads:[~2015-08-05 21:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-05 21:03 [U-Boot] [PATCH 1/3][v2] imx: usb: ehci-mx6: reg accessor cleanups Adrian Alonso
2015-08-05 21:03 ` [U-Boot] [PATCH 2/3][v2] imx: usb: ehci-mx6: document board specific functions Adrian Alonso
2015-08-05 21:31   ` Marek Vasut [this message]
2015-08-05 21:03 ` [U-Boot] [PATCH 3/3][v2] imx: usb: ehci-mx6: add usb support for imx7d soc Adrian Alonso
2015-08-05 21:34   ` Marek Vasut
2015-08-05 21:30 ` [U-Boot] [PATCH 1/3][v2] imx: usb: ehci-mx6: reg accessor cleanups Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201508052331.21740.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox