From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Tue, 11 Aug 2015 03:10:12 +0200 Subject: [U-Boot] [PATCH v3 50/54] mkimage: Set up a file size parameter and keep it updated In-Reply-To: <201508110143.05910.marex@denx.de> References: <1435095556-15924-1-git-send-email-sjg@chromium.org> <201508110143.05910.marex@denx.de> Message-ID: <201508110310.12417.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tuesday, August 11, 2015 at 01:43:05 AM, Marek Vasut wrote: > On Saturday, July 18, 2015 at 01:58:09 AM, Simon Glass wrote: > > On 25 June 2015 at 16:51, Joe Hershberger wrote: > > > Hi Simon, > > > > > > On Tue, Jun 23, 2015 at 4:39 PM, Simon Glass wrote: > > >> Some functions called by mkimage would like to know the output file > > >> size. Initially this is the same as the input file size, but it may be > > >> affected by adding headers, etc. > > >> > > >> Add this information to the image parameters. > > >> > > >> Signed-off-by: Simon Glass > > >> --- > > > > > > Acked-by: Joe Hershberger > > > > Applied to u-boot-dm. > > Hi, > > This breaks all i.MX23 and i.MX28 boards, try building for example the > mx28evk board, u-boot.sb target: > > $ make mx28evk_defconfig > $ make u-boot.sb > [...] > LD spl/lib/built-in.o > LDS spl/u-boot-spl.lds > LD spl/u-boot-spl > OBJCOPY spl/u-boot-spl.bin > CFG spl/u-boot-spl.cfg > MKIMAGE u-boot.sb > ./tools/mkimage: Can't open (null): Bad address > arch/arm/cpu/arm926ejs/mxs/Makefile:82: recipe for target 'u-boot.sb' > failed make[1]: *** [u-boot.sb] Error 1 > Makefile:989: recipe for target 'u-boot.sb' failed > make: *** [u-boot.sb] Error 2 > > Shall I look into it or do you already have a patch ? :) Patch is out and the patch is most certainly correct. On the other hand, is my understanding correct that this patch makes passing the -d option to mkimage mandatory ? It was optional before this patch I believe. Best regards, Marek Vasut