public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Lukasz Majewski <l.majewski@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] usb: gadget: ether: populate _reset_ callback
Date: Tue, 11 Aug 2015 08:51:48 +0200	[thread overview]
Message-ID: <20150811085148.7f35e4d7@amdc2363> (raw)
In-Reply-To: <201508101420.42203.marex@denx.de>

Hi Marek,

> On Monday, August 10, 2015 at 01:15:51 PM, Kishon Vijay Abraham I
> wrote:
> > populate _reset_ callback to the USB ethernet gadget since UDC core
> > expects every gadget driver to have the reset callback. This
> > shouldn't be needed once the ethernet gadget driver is adapted to
> > use the composite driver.
> > 
> > Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> > ---
> >  drivers/usb/gadget/ether.c |    1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/usb/gadget/ether.c b/drivers/usb/gadget/ether.c
> > index 850ba02..53f4672 100644
> > --- a/drivers/usb/gadget/ether.c
> > +++ b/drivers/usb/gadget/ether.c
> > @@ -2505,6 +2505,7 @@ static struct usb_gadget_driver eth_driver = {
> >  	.unbind		= eth_unbind,
> > 
> >  	.setup		= eth_setup,
> > +	.reset		= eth_disconnect,
> >  	.disconnect	= eth_disconnect,
> 
> I'm not sure about this one, Lukasz, can you please comment ?

This is correct.

> 
> > 
> >  	.suspend	= eth_suspend,
> 
> Best regards,
> Marek Vasut

Reviewed-by: Lukasz Majewski <l.majewski@samsung.com>

-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

  reply	other threads:[~2015-08-11  6:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-10 11:15 [U-Boot] [PATCH 0/3] usb: host/gadget: Miscellaneous fixes Kishon Vijay Abraham I
2015-08-10 11:15 ` [U-Boot] [PATCH 1/3] usb: gadget: ether: Perform board initialization from ethernet gadget driver Kishon Vijay Abraham I
2015-08-11  0:33   ` Tom Rini
2015-08-10 11:15 ` [U-Boot] [PATCH 2/3] usb: host: xhci-omap: invoke board_usb_cleanup in xhci_hcd_stop Kishon Vijay Abraham I
2015-08-11  0:33   ` Tom Rini
2015-08-10 11:15 ` [U-Boot] [PATCH 3/3] usb: gadget: ether: populate _reset_ callback Kishon Vijay Abraham I
2015-08-10 12:20   ` Marek Vasut
2015-08-11  6:51     ` Lukasz Majewski [this message]
2015-08-11  0:33   ` Tom Rini
2015-08-11  6:54 ` [U-Boot] [PATCH 0/3] usb: host/gadget: Miscellaneous fixes Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150811085148.7f35e4d7@amdc2363 \
    --to=l.majewski@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox