From mboxrd@z Thu Jan  1 00:00:00 1970
From: Lukasz Majewski <l.majewski@samsung.com>
Date: Tue, 11 Aug 2015 08:51:48 +0200
Subject: [U-Boot] [PATCH 3/3] usb: gadget: ether: populate _reset_
	callback
In-Reply-To: <201508101420.42203.marex@denx.de>
References: <1439205351-14092-1-git-send-email-kishon@ti.com>
 <1439205351-14092-4-git-send-email-kishon@ti.com>
 <201508101420.42203.marex@denx.de>
Message-ID: <20150811085148.7f35e4d7@amdc2363>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Marek,

> On Monday, August 10, 2015 at 01:15:51 PM, Kishon Vijay Abraham I
> wrote:
> > populate _reset_ callback to the USB ethernet gadget since UDC core
> > expects every gadget driver to have the reset callback. This
> > shouldn't be needed once the ethernet gadget driver is adapted to
> > use the composite driver.
> > 
> > Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> > ---
> >  drivers/usb/gadget/ether.c |    1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/usb/gadget/ether.c b/drivers/usb/gadget/ether.c
> > index 850ba02..53f4672 100644
> > --- a/drivers/usb/gadget/ether.c
> > +++ b/drivers/usb/gadget/ether.c
> > @@ -2505,6 +2505,7 @@ static struct usb_gadget_driver eth_driver = {
> >  	.unbind		= eth_unbind,
> > 
> >  	.setup		= eth_setup,
> > +	.reset		= eth_disconnect,
> >  	.disconnect	= eth_disconnect,
> 
> I'm not sure about this one, Lukasz, can you please comment ?

This is correct.

> 
> > 
> >  	.suspend	= eth_suspend,
> 
> Best regards,
> Marek Vasut

Reviewed-by: Lukasz Majewski <l.majewski@samsung.com>

-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group