From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peng Fan <b51431@freescale.com>
Date: Thu, 13 Aug 2015 08:26:04 +0800
Subject: [U-Boot] [PATCH 4/4] imx-common: consolidate macros and
 prototypes into sys_proto.h
In-Reply-To: <55CB6AFB.8060502@denx.de>
References: <1439211227-28030-1-git-send-email-Peng.Fan@freescale.com>
 <1439211227-28030-4-git-send-email-Peng.Fan@freescale.com>
 <55CB6AFB.8060502@denx.de>
Message-ID: <20150813002604.GB25619@shlinux2>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Stefano,
On Wed, Aug 12, 2015 at 05:49:15PM +0200, Stefano Babic wrote:
>Hi Peng,
>
>On 10/08/2015 14:53, Peng Fan wrote:
>> Move most macro definitions and prototypes into
>> "arch/arm/include/asm/imx-common/sys_proto.h" to avoid duplicated
>> function prototypes and marco definitions for different i.MX SoCs.
>> 
>> This patch do not remove the sys_proto.h for different i.MX SoCs,
>> because we need to modify lots of driver code and others. This patch
>> remove duplicated macros and prototypes and incude "sys_proto.h"
>> of imx-common for each sys_proto.h of different i.MX platforms.
>> Then later we should avoid add stuff in sys_proto.h of each platform,
>> and modify driver to include common sys_proto.h.
>> 
>> Signed-off-by: Peng Fan <Peng.Fan@freescale.com>
>> Cc: Stefano Babic <sbabic@denx.de>
>> ---
>>  arch/arm/include/asm/arch-mx31/sys_proto.h  |  7 ++---
>>  arch/arm/include/asm/arch-mx35/sys_proto.h  | 12 ++++----
>>  arch/arm/include/asm/arch-mx5/sys_proto.h   | 22 +-------------
>>  arch/arm/include/asm/arch-mx6/sys_proto.h   | 45 +----------------------------
>>  arch/arm/include/asm/arch-mxs/sys_proto.h   | 15 ++--------
>>  arch/arm/include/asm/imx-common/sys_proto.h | 45 +++++++++++++++++++++++++++++
>>  6 files changed, 59 insertions(+), 87 deletions(-)
>>  create mode 100644 arch/arm/include/asm/imx-common/sys_proto.h
>> 
>
>This breaks MX35 boards:
>
>+In file included from include/asm/arch/sys_proto.h:11:0,
>+                 from arch/arm/cpu/arm1136/mx35/mx35_sdram.c:11:
>+arch/arm/include/asm/imx-common/sys_proto.h:38:23: error: unknown type
>name 'bd_t'
>
>Reason is:
>
>int fecmxc_initialize(bd_t *bis);
>
>Can you check and resubmit ? Thanks !

Oh. I'll check this. I missed to build mx35 target.

[...]

Regards,
Peng.
--